From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Grant Likely <grant.likely@arm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Diana Madalina Craciun <diana.craciun@nxp.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux.cj" <linux.cj@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver
Date: Thu, 18 Feb 2021 17:04:02 +0200 [thread overview]
Message-ID: <CAHp75VdUs8_6_bK1-TS2Bi9vQvLJLsr8C+Y5xXF2_FJHsFKeFQ@mail.gmail.com> (raw)
In-Reply-To: <20210218052654.28995-16-calvin.johnson@oss.nxp.com>
On Thu, Feb 18, 2021 at 7:29 AM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> Modify dpaa2_mac_get_node() to get the dpmac fwnode from either
> DT or ACPI.
>
> Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node
> which is a fwnode.
>
> Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode.
>
> Modify dpaa2_mac_connect() to support ACPI along with DT.
...
> + if (is_of_node(fwnode))
Redundant check I think. If it's not an fwnode, the dpmacs is NULL and
of_node_put() is NULL-aware.
> + of_node_put(dpmacs);
...
> + if (is_of_node(fwnode))
> + of_node_put(dpmacs);
Ditto.
...
> mac->if_link_type = mac->attr.link_type;
> -
Do we need to remove this blank line?
...
> + if (is_of_node(dpmac_node))
> + fwnode_handle_put(dpmac_node);
> + if (is_of_node(dpmac_node))
> + fwnode_handle_put(dpmac_node);
Also not sure that you need a check in the above code excerpts.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-02-18 17:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 5:26 [net-next PATCH v6 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-02-18 19:05 ` Jakub Kicinski
2021-02-18 5:26 ` [net-next PATCH v6 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-02-18 14:52 ` Andy Shevchenko
2021-02-18 5:26 ` [net-next PATCH v6 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 09/15] ACPI: utils: Introduce acpi_get_local_address() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-02-18 15:08 ` Andy Shevchenko
2021-03-08 14:11 ` Calvin Johnson
2021-03-08 14:57 ` Andy Shevchenko
2021-03-08 16:28 ` Calvin Johnson
2021-03-08 16:39 ` Andy Shevchenko
2021-02-18 5:26 ` [net-next PATCH v6 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 13/15] net: phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-02-18 5:26 ` [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2021-02-18 15:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdUs8_6_bK1-TS2Bi9vQvLJLsr8C+Y5xXF2_FJHsFKeFQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=grant.likely@arm.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pieter.jansenvv@bamboosystems.io \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).