From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbdFPKGl (ORCPT ); Fri, 16 Jun 2017 06:06:41 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:34103 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbdFPKGj (ORCPT ); Fri, 16 Jun 2017 06:06:39 -0400 MIME-Version: 1.0 In-Reply-To: <20170616075220.GV5248@pali> References: <20170616073539.1185-1-kai.heng.feng@canonical.com> <20170616075220.GV5248@pali> From: Andy Shevchenko Date: Fri, 16 Jun 2017 13:06:38 +0300 Message-ID: Subject: Re: [PATCH] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Kai-Heng Feng , Matthew Garrett , "dvhart@infradead.org" , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5GA6jJI008405 On Fri, Jun 16, 2017 at 10:52 AM, Pali Rohár wrote: > On Friday 16 June 2017 15:35:39 Kai-Heng Feng wrote: >> - if (kbd_token_bits != 0 || ret == 0) >> + /* >> + * If KBD_LED_OFF_TOKEN is the only token, >> + * consider there is no keyboard backlight. >> + */ >> + if ((kbd_token_bits & ~BIT(5)) != 0 || ret == 0) > > Should not this check to be rather: > > (kbd_token_bits != 0 && (kbd_token_bits & BIT(KBD_LED_OFF_TOKEN)) != BIT(KBD_LED_OFF_TOKEN)) > > To express that we have at least one token at it is different from > KBD_LED_OFF_TOKEN token? Isn't the same to (kbd_token_bits ^ BIT(KBD_LED_OFF_TOKEN)) ? -- With Best Regards, Andy Shevchenko