From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
linux-arm-msm@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v6 3/8] regulator: IRQ based event/error notification helpers
Date: Thu, 8 Apr 2021 12:58:05 +0300 [thread overview]
Message-ID: <CAHp75VdYniyc8jovg9VDgwQ+_VjYOoAubB_QSokEN+REcnKTrw@mail.gmail.com> (raw)
In-Reply-To: <23c73081365fddce2950c101a51fc2baaaa37aa5.camel@fi.rohmeurope.com>
On Thu, Apr 8, 2021 at 11:21 AM Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> wrote:
>
> Hello Andy,
>
> On Wed, 2021-04-07 at 16:21 +0300, Andy Shevchenko wrote:
> > On Wed, Apr 7, 2021 at 1:04 PM Matti Vaittinen
> > <matti.vaittinen@fi.rohmeurope.com> wrote:
> > > Provide helper function for IC's implementing regulator
> > > notifications
> > > when an IRQ fires. The helper also works for IRQs which can not be
> > > acked.
> > > Helper can be set to disable the IRQ at handler and then re-
> > > enabling it
> > > on delayed work later. The helper also adds
> > > regulator_get_error_flags()
> > > errors in cache for the duration of IRQ disabling.
> >
> > Thanks for an update, my comments below. After addressing them, feel
> > free to add
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> I (eventually) disagreed with couple of points here and haven't changed
> those. Please see list below.
>
> I still do think you did a really good job reviewing this - and you
> should get the recognition from that work. Thus I'd nevertheless would
> like to add your Reviewed-by to the next version. Please let me know if
> you think it's ok. (I have the v7 ready but I'll wait until the next
> Monday before sending it to see if this brings more discussion).
Looks OK to me.
Just rename die_loudly() to rdev_die_loudly() and in any way of
conditionals with that, please mark it with __noreturn attribute, so
if (bla bla bla)
rdev_die_loudly();
will be an understandable trap.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-08 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:02 [PATCH v6 0/8] Extend regulator notification support Matti Vaittinen
2021-04-07 10:02 ` [PATCH v6 1/8] dt_bindings: Add protection limit properties Matti Vaittinen
2021-04-07 10:03 ` [PATCH v6 2/8] regulator: add warning flags Matti Vaittinen
2021-04-07 10:04 ` [PATCH v6 3/8] regulator: IRQ based event/error notification helpers Matti Vaittinen
2021-04-07 13:21 ` Andy Shevchenko
2021-04-08 5:22 ` Matti Vaittinen
2021-04-08 8:21 ` Matti Vaittinen
2021-04-08 9:58 ` Andy Shevchenko [this message]
2021-04-08 10:06 ` Vaittinen, Matti
2021-04-07 10:04 ` [PATCH v6 4/8] regulator: add property parsing and callbacks to set protection limits Matti Vaittinen
2021-04-07 10:04 ` [PATCH v6 5/8] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW Matti Vaittinen
2021-04-08 15:22 ` Rob Herring
2021-04-07 10:05 ` [PATCH v6 6/8] regulator: bd9576: Support error reporting Matti Vaittinen
2021-04-07 10:06 ` [PATCH v6 7/8] regulator: bd9576: Fix the driver name in id table Matti Vaittinen
2021-04-07 10:06 ` [PATCH v6 8/8] MAINTAINERS: Add reviewer for regulator irq_helpers Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdYniyc8jovg9VDgwQ+_VjYOoAubB_QSokEN+REcnKTrw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).