linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Kent Gibson <warthog618@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v10 00/20] gpio: cdev: add uAPI v2
Date: Tue, 29 Sep 2020 19:22:13 +0300	[thread overview]
Message-ID: <CAHp75Vdc4eVA6nLJNhH3R2LVvh4ibuVohmQMURiwPb4WxA_84Q@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJVV5bCVAbC9WPsZwXqvYvnPLHAqEqky8w-iuPO4pDgeAQ@mail.gmail.com>

On Tue, Sep 29, 2020 at 6:13 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Mon, Sep 28, 2020 at 2:28 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > This patchset defines and implements a new version of the
> > GPIO CDEV uAPI to address existing 32/64-bit alignment issues, add
> > support for debounce, event sequence numbers, and allow for requested
> > lines with different configurations.
> > It provides some future proofing by adding optional configuration fields
> > and padding reserved for future use.
> >
> > The series can be partitioned into three blocks; the first two patches
> > are minor fixes that impact later patches, the next eleven contain the
> > v2 uAPI definition and implementation, and the final seven port the GPIO
> > tools to the v2 uAPI and extend them to use new uAPI features.
> >
> > The more complicated patches include their own commentary where
> > appropriate.

> This series looks great now. Unless there are new objections I intend
> on picking it up tomorrow.

Various nit-picks, if any, can be addressed later on.

-- 
With Best Regards,
Andy Shevchenko

      reply	other threads:[~2020-09-29 16:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  0:27 [PATCH v10 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-09-28  0:27 ` [PATCH v10 01/20] gpiolib: cdev: gpio_desc_to_lineinfo() should set info offset Kent Gibson
2020-09-28  0:27 ` [PATCH v10 02/20] gpiolib: cdev: replace strncpy() with strscpy() Kent Gibson
2020-09-28  0:27 ` [PATCH v10 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-09-28  0:27 ` [PATCH v10 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-28  0:27 ` [PATCH v10 05/20] gpiolib: make cdev a build option Kent Gibson
2020-09-28  0:27 ` [PATCH v10 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-09-28  0:27 ` [PATCH v10 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-28  0:27 ` [PATCH v10 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-09-28  0:27 ` [PATCH v10 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-28  0:27 ` [PATCH v10 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-09-28  0:27 ` [PATCH v10 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-09-28  0:27 ` [PATCH v10 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-09-28  0:28 ` [PATCH v10 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-09-28  0:28 ` [PATCH v10 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-09-28  0:28 ` [PATCH v10 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-09-28  0:28 ` [PATCH v10 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-09-28  0:28 ` [PATCH v10 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-09-28  0:28 ` [PATCH v10 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-09-28  0:28 ` [PATCH v10 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-09-28  0:28 ` [PATCH v10 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-29 15:13 ` [PATCH v10 00/20] gpio: cdev: add uAPI v2 Bartosz Golaszewski
2020-09-29 16:22   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Vdc4eVA6nLJNhH3R2LVvh4ibuVohmQMURiwPb4WxA_84Q@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).