From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751496AbdAMWaK (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 17:30:10 -0500
Received: from mail-qt0-f193.google.com ([209.85.216.193]:36127 "EHLO
        mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750901AbdAMWaJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 17:30:09 -0500
MIME-Version: 1.0
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D7012363F1@RTITMBSV03.realtek.com.tw>
References: <20170112120101.16933-1-shrirang.bagul@canonical.com>
 <20170112120101.16933-2-shrirang.bagul@canonical.com> <ABFD875FF5FB574BA706497D987D48D7012363F1@RTITMBSV03.realtek.com.tw>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sat, 14 Jan 2017 00:30:08 +0200
Message-ID: <CAHp75VdeAZH9U=xnzva+vkTE_3jH7i7tRDQPmKcJ3TTdmj=J8A@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support
To: Bard Liao <bardliao@realtek.com>
Cc: Shrirang Bagul <shrirang.bagul@canonical.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 13, 2017 at 4:53 AM, Bard Liao <bardliao@realtek.com> wrote:
>> +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = {
>> +     { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 },
>> +     { "lineout-mute-gpios", &lineout_mute_gpio, 1 },
>> +     { NULL },
>> +};
>> +
>
> I am thinking if it is more suitable to move the gpio params to
> machine driver? They are not codec's gpios and are only used
> by machine driver.

Generally speaking those properties should come per ACPI ID. So, they
should share the same module which has MODULE_DEVICE_TABLE(acpi, ...)
defined.

-- 
With Best Regards,
Andy Shevchenko