From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CFDC433F5 for ; Mon, 31 Jan 2022 16:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349952AbiAaQaF (ORCPT ); Mon, 31 Jan 2022 11:30:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232284AbiAaQaD (ORCPT ); Mon, 31 Jan 2022 11:30:03 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23C37C061714; Mon, 31 Jan 2022 08:30:03 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id k25so44437396ejp.5; Mon, 31 Jan 2022 08:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vRDplifUhsb5m6qIz40Anhg2xj6DslUkXFz6GsVymy4=; b=D93WKL0bH3y0DsemI7NcPaBG2KnCtuCJsu1Kw+N+S/H4CUAQsHVB2XSUXCiMQXeqJp vSdxRC6Lp34sxJEQZaapbcutOoLdIpe6q0qqcvGnEXInFE/3jRUl2dFKFFAxwCrcsvQz R9OaaN0daXTLHr27vJo3gSJlzS8kcXWUc5yjsuiylmQLpnk6jPlx60odaFILHliLwy2N LMuaJrLRjx+ioy1WHnxzDNgEnu8Zqg7uOl+3phVC4d3EwYl8PyB5dgt8JTyEdy6EemdL th8OghN8ysl/lzJV1BeGWvu/BSp8KfEpWjw5hd17vz26Se44IzXpg2BN3SM9LeLRpORx XREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vRDplifUhsb5m6qIz40Anhg2xj6DslUkXFz6GsVymy4=; b=adz9dvfYFwxHLCb3+6bW7gS8i6tSDL1bwN7f5oFEn+ca1TMtSZYkIhVnjH2Tiu9F0L 4VGQl7uo8cHECy2F+50Dte/hFyv83TBr/Be2lDz0H38h4Y77kkyYhJNDU9eAzsKBLy1e 4sdrQUD5bfjZ3hcDT3ZiPzsRE7KsHxnMLf+V1h7tA5Rk7fhJ70EAVM6sjkebm35U+WEV /uoVO+g9Nd4s0xQdPmZl4jV9lMpeAvVYvK/R7x+Z+hLcy3k3bLuSxgXZkgXr4MtIBGLq G5SjBI/6QzrEiHGTkRxqctsykuWQbess1xFylUxytTEM3PwUN5iS3YgF2Zg9sW+Wtbhi Kfxg== X-Gm-Message-State: AOAM530juDAlGqrjSMEK7/gPwVIcU2TUGxhadM3s5+SUCF9nlr+5WiS3 awZLvV5W9ALn1A/sh1yLC9Xc9KTTMHYeI8yJ7bI= X-Google-Smtp-Source: ABdhPJwH3lAp3JlumSNQ61ldPCI4Vyq+OLtFCZ0qJsy2dxhZ6fQQm1lW9Qqm6EetQhoC0xmpiPhNQt1zsrbA/2qNhWo= X-Received: by 2002:a17:906:7948:: with SMTP id l8mr17420594ejo.636.1643646601634; Mon, 31 Jan 2022 08:30:01 -0800 (PST) MIME-Version: 1.0 References: <20220131160713.245637-1-marcan@marcan.st> <20220131160713.245637-4-marcan@marcan.st> In-Reply-To: <20220131160713.245637-4-marcan@marcan.st> From: Andy Shevchenko Date: Mon, 31 Jan 2022 18:28:25 +0200 Message-ID: Subject: Re: [PATCH v4 3/9] brcmfmac: firmware: Do not crash on a NULL board_type To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , "open list:TI WILINK WIRELES..." , netdev , devicetree , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , SHA-cyfmac-dev-list@infineon.com, Arend van Spriel , Stable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 31, 2022 at 6:07 PM Hector Martin wrote: > > This unbreaks support for USB devices, which do not have a board_type > to create an alt_path out of and thus were running into a NULL > dereference. ... > @@ -599,6 +599,9 @@ static char *brcm_alt_fw_path(const char *path, const char *board_type) > char alt_path[BRCMF_FW_NAME_LEN]; > char suffix[5]; > > + if (!board_type) > + return NULL; I still think it's better to have both callers do the same thing. Now it will be the double check in one case, -- With Best Regards, Andy Shevchenko