From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: chenlei0x@gmail.com
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lei Chen <lennychen@tencent.com>
Subject: Re: [PATCH] driver: pinctrl: fix unused variable warning
Date: Fri, 11 Dec 2020 20:58:15 +0200 [thread overview]
Message-ID: <CAHp75VdmC2QyVYz_QcbgpdMwkJ5VndUwp=rmk=b0KSZcwZrqkg@mail.gmail.com> (raw)
In-Reply-To: <1607659581-15764-1-git-send-email-lennychen@tencent.com>
On Fri, Dec 11, 2020 at 1:46 PM <chenlei0x@gmail.com> wrote:
>
> From: Lei Chen <lennychen@tencent.com>
>
> In pinctrl_pins_show, range, gpio_num and chip variables are not used if
> CONFIG_GPIOLIB is not defined. Use this macro to wrap them.
>
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/drivers/pinctrl/core.c?h=for-next&id=b507cb92477ad85902783a183c5ce01d16296687
Rule of thumb: base your patches on the latest subsystem tree snapshot.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-12-11 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 4:06 [PATCH] driver: pinctrl: fix unused variable warning chenlei0x
2020-12-11 18:58 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdmC2QyVYz_QcbgpdMwkJ5VndUwp=rmk=b0KSZcwZrqkg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=chenlei0x@gmail.com \
--cc=lennychen@tencent.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).