From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq
Date: Fri, 23 Feb 2018 18:13:41 +0200 [thread overview]
Message-ID: <CAHp75VdpwSoGiDze7HMWCxXZcmT_MdkBPDyYyP-G3CAQjoO0Lw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdAsEQNKRnTRKnpY+X2Ph=B17dNQ_1==2OkRKcs7ma5KA@mail.gmail.com>
On Fri, Feb 23, 2018 at 5:59 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Feb 23, 2018 at 5:36 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> IIRC memcpy_toio() doesn't increment the destination address.
>
> lo_hi or hi_lo helpers sound better.
Ah, sorry, I messed up with writesl() / etc.
memcpy_toio() has another side-effect, but here it seems unimportant.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-02-23 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 15:36 [PATCH] scsi: lpfc: use memcpy_toio instead of writeq Arnd Bergmann
2018-02-23 15:59 ` Andy Shevchenko
2018-02-23 16:13 ` Andy Shevchenko [this message]
2018-02-23 16:41 ` David Laight
2018-02-23 16:44 ` Arnd Bergmann
2018-02-23 16:51 ` Andy Shevchenko
2018-02-23 16:53 ` Andy Shevchenko
2018-02-23 17:09 ` David Laight
2018-02-23 17:12 ` Andy Shevchenko
2018-02-23 17:45 ` David Laight
2018-02-23 21:02 ` Arnd Bergmann
2018-02-24 22:24 ` James Smart
2018-02-25 10:02 ` Johannes Thumshirn
2018-02-26 9:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdpwSoGiDze7HMWCxXZcmT_MdkBPDyYyP-G3CAQjoO0Lw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).