From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] iio:temperature:mlx90632: Reduce number of equal calulcations
Date: Sat, 8 Aug 2020 13:31:58 +0300 [thread overview]
Message-ID: <CAHp75VdvCMaz4d+moE-nNWJ49NYfa-UR85cdp75GscCLPO=bhA@mail.gmail.com> (raw)
In-Reply-To: <20200807232104.1256119-2-cmo@melexis.com>
On Sat, Aug 8, 2020 at 2:22 AM Crt Mori <cmo@melexis.com> wrote:
>
> TAdut4 was calculated each iteration although it did not change. In light
> of near future additions of the Extended range DSP calculations, this
> function refactoring will help reduce unrelated changes in that series as
> well as reduce the number of new functions needed.
I see you provided a helper for this calculus, but I think we may
reduce a lot of churn if you do the following:
- introduce helper and convert one/current user (no functional change!)
- do what you did in this patch, but it will move less LOCs
- do what you have done in the next one using the helper
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-08 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 23:21 [PATCH v3 0/2] iio: temperature: mlx90632: Add extended calibration calculations Crt Mori
2020-08-07 23:21 ` [PATCH v3 1/2] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-08 10:31 ` Andy Shevchenko [this message]
2020-08-07 23:21 ` [PATCH v3 2/2] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-08 10:44 ` Andy Shevchenko
2020-08-08 11:02 ` Crt Mori
2020-08-08 10:29 ` [PATCH v3 0/2] iio: temperature: mlx90632: Add extended calibration calculations Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdvCMaz4d+moE-nNWJ49NYfa-UR85cdp75GscCLPO=bhA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).