From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D55C43334 for ; Mon, 4 Jul 2022 21:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbiGDVOn (ORCPT ); Mon, 4 Jul 2022 17:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiGDVOl (ORCPT ); Mon, 4 Jul 2022 17:14:41 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3343A62FA; Mon, 4 Jul 2022 14:14:41 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-31c89653790so40660287b3.13; Mon, 04 Jul 2022 14:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HpdquBLgwxS+q6MF90ETAqdi+gZ5jGI/bw3VMe7+rpM=; b=pisWhvytYZKcu+6yG4fRYH2VSnfWPvpTWA+gGM2H9VsDnz1Nib2CFiFmg3pHrwfMLA jDwEDffpRMjn8/A+wioAF9Cq2+qv8EhBQqcsEuO3EMmu14Zw8HGGpmsNHlSX+BjaPIYz v9swYPqNcfcEpwpvhj9RHrNU7Kr3NnRhPDvVKnrmzZYXLtriCDIeXN+U0W9ia0fF5mRC Fs4O7JBhbxC04sxj2Jq4uzhG+waPhMmluTQCcYWdp949oDqMk74B2o8JYRErDbJgojw7 iC21Q1WweofBJD8188y54cG3nP/c8Wr4aV16mZq9v2Xdu0smJbbPholxpaf2ZKiPz9cp KVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HpdquBLgwxS+q6MF90ETAqdi+gZ5jGI/bw3VMe7+rpM=; b=VOl4e269lOWlr8ReE/y+0/TNbofjzf/XbFLlXiaFvOh1IOv7iuq3dgBgJhHMN5mhp4 o2Z9FDufcebfwGpLgySdDrNs19o55/aTgkUFEJaf/EtUdXF8lN+SDiG33s/g/nGxbpdA O5Dqkqs4QV4nCCyeENUrJEm7uh4sKQbCD2xIcgfaTrWbZHmXtP1fLL31YM4i1KVrKEWZ P3Lk6XZTkPzuxICIvOJtYxANy99YSgIFnRklAE7KHc/hRhcbXA5pstg1GGkvBb4+z91b AAuaaanuTqOdDZ8G0xzgnZqyeRCenzQ54XOuJyeSNfjMEPLVlKy4qryMN4OJTUkEwwkH ygWg== X-Gm-Message-State: AJIora8LKbIj+8itcSIP4P+LD7CIA8BxDgqK2ryIaJaigHOh4P/yBwvZ xJqf13Amg6j7XxVeH3d5D9IeKtzAGO3CThyU2fo= X-Google-Smtp-Source: AGRyM1vYxguLbsBOzRTVw1vvx756PgfmGkkRGrCT+1/7YzT9o6SbOC3eiybdUymDSM+qqhALtY73LfI5pY/jFLAqsJ8= X-Received: by 2002:a81:468b:0:b0:318:4cac:6576 with SMTP id t133-20020a81468b000000b003184cac6576mr34256097ywa.277.1656969280331; Mon, 04 Jul 2022 14:14:40 -0700 (PDT) MIME-Version: 1.0 References: <20220704053901.728-1-peterwu.pub@gmail.com> <20220704053901.728-14-peterwu.pub@gmail.com> In-Reply-To: <20220704053901.728-14-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Mon, 4 Jul 2022 23:14:03 +0200 Message-ID: Subject: Re: [PATCH v4 13/13] video: backlight: mt6370: Add Mediatek MT6370 support To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu wrote: > > From: ChiaEn Wu > > Add Mediatek MT6370 Backlight support. ... > + This driver can also be built as a module. If so the module If so, > + will be called "mt6370-backlight.ko". No ".ko" part. ... > +#include Can you elaborate on this? > +#include > +#include > +#include > +#include > +#include Can you elaborate on this? > +#include > +#include Missed mod_devicetable.h. ... > + brightness_val[0] = (brightness - 1) & MT6370_BL_DIM2_MASK; > + brightness_val[1] = (brightness - 1) > + >> fls(MT6370_BL_DIM2_MASK); Bad indentation. One line? ... > + if (priv->enable_gpio) Dup check. > + gpiod_set_value(priv->enable_gpio, brightness ? 1 : 0); ... > + brightness = brightness_val[1] << fls(MT6370_BL_DIM2_MASK); > + brightness += (brightness_val[0] & MT6370_BL_DIM2_MASK); Too many parentheses. ... > + /* > + * prop_val = 1 --> 1 steps --> 0x00 > + * prop_val = 2 ~ 4 --> 4 steps --> 0x01 > + * prop_val = 5 ~ 16 --> 16 steps --> 0x10 > + * prop_val = 17 ~ 64 --> 64 steps --> 0x11 > + */ > + prop_val = (ilog2(roundup_pow_of_two(prop_val)) + 1) >> 1; Isn't something closer to get_order() or fls()? ... > + props->max_brightness = min_t(u32, brightness, > + MT6370_BL_MAX_BRIGHTNESS); One line? ... > + val = 0; Do you need this here? > + prop_val = 0; Useless. > + ret = device_property_read_u8(dev, "mediatek,bled-channel-use", > + &prop_val); > + if (ret) { > + dev_err(dev, "mediatek,bled-channel-use DT property missing\n"); > + return ret; > + } > + > + if (!prop_val || prop_val > MT6370_BL_MAX_CH) { > + dev_err(dev, > + "No channel specified or over than upper bound (%d)\n", > + prop_val); > + return -EINVAL; > + } ... > +static int mt6370_bl_probe(struct platform_device *pdev) > +{ > + struct mt6370_priv *priv; > + struct backlight_properties props = { > + .type = BACKLIGHT_RAW, > + .scale = BACKLIGHT_SCALE_LINEAR, > + }; > + int ret; struct device *dev = &pdev->dev; will save you a few LoCs. -- With Best Regards, Andy Shevchenko