linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any
@ 2016-12-16 14:46 Michał Kępień
  2016-12-17  1:30 ` Jonathan Woithe
  2016-12-27 11:51 ` Andy Shevchenko
  0 siblings, 2 replies; 3+ messages in thread
From: Michał Kępień @ 2016-12-16 14:46 UTC (permalink / raw)
  To: Jonathan Woithe, Darren Hart; +Cc: platform-driver-x86, linux-kernel

The "radio components indicator" LED present in Lifebook E734/E744/E754
should be lit when any radio transmitter is enabled, so set its default
trigger to rfkill-any.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
---
Note: the rfkill-any trigger is currently only present in
mac80211-next/master.

 drivers/platform/x86/fujitsu-laptop.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 61f39ab..bfc0eb3 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
 
 static struct led_classdev radio_led = {
  .name = "fujitsu::radio_led",
+ .default_trigger = "rfkill-any",
  .brightness_get = radio_led_get,
  .brightness_set = radio_led_set
 };
-- 
2.10.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any
  2016-12-16 14:46 [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any Michał Kępień
@ 2016-12-17  1:30 ` Jonathan Woithe
  2016-12-27 11:51 ` Andy Shevchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Woithe @ 2016-12-17  1:30 UTC (permalink / raw)
  To: Micha?? K??pie??; +Cc: Darren Hart, platform-driver-x86, linux-kernel

On Fri, Dec 16, 2016 at 03:46:03PM +0100, Micha?? K??pie?? wrote:
> The "radio components indicator" LED present in Lifebook E734/E744/E754
> should be lit when any radio transmitter is enabled, so set its default
> trigger to rfkill-any.

This shouldn't cause any problems.  At the end of the day it's only the
default; if for some reason it's inappropriate for any systems we could do
an override.

Acked-by: Jonathan Woithe <jwoithe@just42.net>

> Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl>
> ---
> Note: the rfkill-any trigger is currently only present in
> mac80211-next/master.
> 
>  drivers/platform/x86/fujitsu-laptop.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 61f39ab..bfc0eb3 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
>  
>  static struct led_classdev radio_led = {
>   .name = "fujitsu::radio_led",
> + .default_trigger = "rfkill-any",
>   .brightness_get = radio_led_get,
>   .brightness_set = radio_led_set
>  };

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any
  2016-12-16 14:46 [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any Michał Kępień
  2016-12-17  1:30 ` Jonathan Woithe
@ 2016-12-27 11:51 ` Andy Shevchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2016-12-27 11:51 UTC (permalink / raw)
  To: Michał Kępień
  Cc: Jonathan Woithe, Darren Hart, platform-driver-x86, linux-kernel

On Fri, Dec 16, 2016 at 4:46 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> The "radio components indicator" LED present in Lifebook E734/E744/E754
> should be lit when any radio transmitter is enabled, so set its default
> trigger to rfkill-any.
>

Pushed to testing, thanks!

> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> ---
> Note: the rfkill-any trigger is currently only present in
> mac80211-next/master.
>
>  drivers/platform/x86/fujitsu-laptop.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 61f39ab..bfc0eb3 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev,
>
>  static struct led_classdev radio_led = {
>   .name = "fujitsu::radio_led",
> + .default_trigger = "rfkill-any",
>   .brightness_get = radio_led_get,
>   .brightness_set = radio_led_set
>  };
> --
> 2.10.2
>



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-27 11:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 14:46 [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any Michał Kępień
2016-12-17  1:30 ` Jonathan Woithe
2016-12-27 11:51 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).