From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH v2 0/2] Add CTS/RTS gpio support to STM32 UART
Date: Fri, 17 Apr 2020 00:30:28 +0300 [thread overview]
Message-ID: <CAHp75Ve6V+gm_KXqMpG8bn7KtHjOctomZwk8n_6xwtx6cFdKfw@mail.gmail.com> (raw)
In-Reply-To: <20200416175729.5550-1-mani@kernel.org>
On Thu, Apr 16, 2020 at 8:58 PM <mani@kernel.org> wrote:
>
> From: Manivannan Sadhasivam <mani@kernel.org>
>
> Hello,
>
> This patchset adds CTS/RTS gpio support to STM32 UART controller.
> Eventhough the UART controller supports using dedicated CTS/RTS gpios,
> sometimes we need to use different set of gpios for flow control.
>
> This is necessary for the upcoming STM32MP1 based board called Stinger96
> IoT-Box. On that board, a bluetooth chip is connected to one of the UART
> controller but the CTS/RTS lines got swapped mistakenly. So this patchset
> serves as a workaround for that hardware bug and also supports the
> usecase of using any gpio for CTS/RTS functionality. As per the sugggestion
> provided by Andy for v1, I've now switched to mctrl_gpio driver.
>
> This patchset has been validated with Stinger96 IoT-Box connected to Murata
> WiFi-BT combo chip.
>
Looks good to me,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Thanks,
> Mani
>
> Changes in v2:
>
> As per the review by Andy:
>
> * Switched to mctrl_gpio driver instead of using custom CTS/RTS
> implementation
> * Removed the use of software flow control terminology.
>
> Manivannan Sadhasivam (2):
> tty: serial: Add modem control gpio support for STM32 UART
> dt-bindings: serial: Document CTS/RTS gpios in STM32 UART
>
> .../bindings/serial/st,stm32-uart.yaml | 14 ++++++
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/stm32-usart.c | 43 ++++++++++++++++++-
> drivers/tty/serial/stm32-usart.h | 1 +
> 4 files changed, 58 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-04-16 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 17:57 [PATCH v2 0/2] Add CTS/RTS gpio support to STM32 UART mani
2020-04-16 17:57 ` [PATCH v2 1/2] tty: serial: Add modem control gpio support for " mani
2020-04-17 13:15 ` Fabrice Gasnier
2020-04-20 17:51 ` Manivannan Sadhasivam
2020-04-16 17:57 ` [PATCH v2 2/2] dt-bindings: serial: Document CTS/RTS gpios in " mani
2020-04-16 21:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve6V+gm_KXqMpG8bn7KtHjOctomZwk8n_6xwtx6cFdKfw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mani@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).