From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
devicetree <devicetree@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
Darius <Darius.Berghe@analog.com>
Subject: Re: [RESEND PATCH v9 2/2] iio: accel: Add driver support for ADXL355
Date: Tue, 10 Aug 2021 15:39:11 +0300 [thread overview]
Message-ID: <CAHp75Ve=fnib8YzVH_5LySgQDiWCxNzsJYBBLtB68GrSOCT9SQ@mail.gmail.com> (raw)
In-Reply-To: <20210809205141.193d24dc@jic23-huawei>
On Mon, Aug 9, 2021 at 11:56 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon, 9 Aug 2021 13:37:29 +0530
> Puranjay Mohan <puranjay12@gmail.com> wrote:
>
> > ADXL355 is 3-axis MEMS Accelerometer. It offers low noise density,
> > low 0g offset drift, low power with selectable measurement ranges.
> > It also features programmable high-pass and low-pass filters.
> >
> > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adxl354_adxl355.pdf
> > Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
>
> One odd formatting thing below (tab where it should be a space)
> that I can fix whilst applying if you don't have other reasons to
> do a v10.
>
> Otherwise, looks good to me.
I just reviewed a previous "v9" and I have quite a few comments I
think can be addressed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-10 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 8:07 [RESEND PATCH v9 0/2] iio: accel: add support for ADXL355 Puranjay Mohan
2021-08-09 8:07 ` [RESEND PATCH v9 1/2] dt-bindings: iio: accel: Add DT binding doc " Puranjay Mohan
2021-08-09 8:07 ` [RESEND PATCH v9 2/2] iio: accel: Add driver support " Puranjay Mohan
2021-08-09 19:51 ` Jonathan Cameron
2021-08-10 12:39 ` Andy Shevchenko [this message]
2021-08-09 20:02 ` [RESEND PATCH v9 0/2] iio: accel: add " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve=fnib8YzVH_5LySgQDiWCxNzsJYBBLtB68GrSOCT9SQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).