From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Terry Bowman <terry.bowman@amd.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wolfram Sang <wsa@kernel.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
katie.morris@in-advantage.com,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module
Date: Wed, 3 Aug 2022 13:32:01 +0200 [thread overview]
Message-ID: <CAHp75VeBzKW16ncVw+_BqmBkwg=B-Uk7+UiuXko8ymiEN08kzg@mail.gmail.com> (raw)
In-Reply-To: <20220803054728.1541104-4-colin.foster@in-advantage.com>
On Wed, Aug 3, 2022 at 7:47 AM Colin Foster
<colin.foster@in-advantage.com> wrote:
>
> Work is being done to allow external control of Ocelot chips. When pinctrl
> drivers are used internally, it wouldn't make much sense to allow them to
> be loaded as modules. In the case where the Ocelot chip is controlled
> externally, this scenario becomes practical.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>
> (No changes since before v14)
>
> v14
> * No changes
>
> ---
> drivers/pinctrl/Kconfig | 7 ++++++-
> drivers/pinctrl/pinctrl-ocelot.c | 6 +++++-
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f52960d2dfbe..ba48ff8be6e2 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -311,7 +311,7 @@ config PINCTRL_MICROCHIP_SGPIO
> LED controller.
>
> config PINCTRL_OCELOT
> - bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs"
> + tristate "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs"
> depends on OF
> depends on HAS_IOMEM
> select GPIOLIB
> @@ -321,6 +321,11 @@ config PINCTRL_OCELOT
> select GENERIC_PINMUX_FUNCTIONS
> select OF_GPIO
> select REGMAP_MMIO
> + help
> + Support for the internal GPIO interfaces on Microsemi Ocelot and
> + Jaguar2 SoCs.
> +
> + If conpiled as a module, the module name will be pinctrl-ocelot.
>
> config PINCTRL_OXNAS
> bool
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index 5f4a8c5c6650..d18047d2306d 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -1889,6 +1889,7 @@ static const struct of_device_id ocelot_pinctrl_of_match[] = {
> { .compatible = "microchip,lan966x-pinctrl", .data = &lan966x_desc },
> {},
> };
> +MODULE_DEVICE_TABLE(of, ocelot_pinctrl_of_match);
>
> static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
> {
> @@ -1984,4 +1985,7 @@ static struct platform_driver ocelot_pinctrl_driver = {
> },
> .probe = ocelot_pinctrl_probe,
> };
> -builtin_platform_driver(ocelot_pinctrl_driver);
> +module_platform_driver(ocelot_pinctrl_driver);
> +
> +MODULE_DESCRIPTION("Ocelot Chip Pinctrl Driver");
> +MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-03 11:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 5:47 [PATCH v15 mfd 0/9] add support for VSC7512 control over SPI Colin Foster
2022-08-03 5:47 ` [PATCH v15 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-08-03 11:31 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:31 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster
2022-08-03 11:32 ` Andy Shevchenko [this message]
2022-08-03 5:47 ` [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:32 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-08-03 11:32 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:32 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 7/9] resource: add define macro for register address resources Colin Foster
2022-08-03 11:33 ` Andy Shevchenko
2022-08-03 5:47 ` [PATCH v15 mfd 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-08-03 5:47 ` [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-08-03 11:45 ` Andy Shevchenko
2022-08-03 15:56 ` Colin Foster
2022-08-03 17:10 ` Andy Shevchenko
2022-08-03 17:31 ` Colin Foster
2022-08-05 17:44 ` Colin Foster
2022-08-05 17:58 ` Andy Shevchenko
2022-08-05 18:07 ` Colin Foster
2022-08-05 18:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeBzKW16ncVw+_BqmBkwg=B-Uk7+UiuXko8ymiEN08kzg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=katie.morris@in-advantage.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=terry.bowman@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).