From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Faiyaz Mohammed <faiyazm@codeaurora.org>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>,
glittao@gmail.com, vinmenon@codeaurora.org
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs
Date: Mon, 7 Jun 2021 19:42:32 +0300 [thread overview]
Message-ID: <CAHp75VeCLyOSExxLGSaTzR3OgE+_PGe4FxraCK8T3sn6yS6-uQ@mail.gmail.com> (raw)
In-Reply-To: <d5c16162-91af-40ba-66dc-02ac5a6a48ef@codeaurora.org>
On Mon, Jun 7, 2021 at 4:55 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
...
> >> + if (num_online_cpus() > 1 &&
> >> + !cpumask_empty(to_cpumask(l->cpus)))
> >
> > One line?
> >
> I have split the line because it is crossing the 80 columns. In this
> case it's okay to cross 80 columns?
For how many characters? If it's 3 or 4 or so, it's fine to have it on
one line. Use common sense here.
...
> >> + debugfs_remove_recursive(debugfs_lookup(s->name,
> >> + slab_debugfs_root));
> >
> > One line?
> >
> Same here!
Same here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-07 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 16:14 [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs Faiyaz Mohammed
2021-06-06 18:44 ` kernel test robot
2021-06-06 20:31 ` Andy Shevchenko
2021-06-07 2:40 ` Faiyaz Mohammed
2021-06-07 8:42 ` Andy Shevchenko
2021-06-07 13:54 ` Faiyaz Mohammed
2021-06-07 16:42 ` Andy Shevchenko [this message]
2021-06-07 2:01 ` Faiyaz Mohammed
2021-06-07 10:12 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeCLyOSExxLGSaTzR3OgE+_PGe4FxraCK8T3sn6yS6-uQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=faiyazm@codeaurora.org \
--cc=glittao@gmail.com \
--cc=greg@kroah.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).