linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Lee Jones <lee.jones@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional
Date: Fri, 2 Jul 2021 17:14:00 +0300	[thread overview]
Message-ID: <CAHp75VeD4Ph_276jNQROkymTmcEXZECBY+Ci8xdGySv0fQYMXg@mail.gmail.com> (raw)
In-Reply-To: <YN8YfTHFDc1a9z0d@lunn.ch>

On Fri, Jul 2, 2021 at 4:45 PM Andrew Lunn <andrew@lunn.ch> wrote:
> On Fri, Jul 02, 2021 at 02:23:47PM +0200, Matthias Schiffer wrote:
> > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This
> > causes warnings with newer kernels.
> >
> > Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a
> > missing IRQ properly.

...

> It is a shame platform_get_irq_optional() does something different to
> all the other _optional() calls :-(

Exactly my point when I proposed the change to it!

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-07-02 14:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 12:23 [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Matthias Schiffer
2021-07-02 12:23 ` [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Matthias Schiffer
2021-07-02 13:45   ` Andrew Lunn
2021-07-02 14:14     ` Andy Shevchenko [this message]
2021-07-02 12:23 ` [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-07-02 13:52   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Matthias Schiffer
2021-07-02 13:56   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 4/7] mfd: tqmx86: fix typo in "platform" Matthias Schiffer
2021-07-02 14:00   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Matthias Schiffer
2021-07-02 14:04   ` Andrew Lunn
2021-07-02 13:41 ` [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Andrew Lunn
2021-07-05  7:13   ` Matthias Schiffer
2021-07-16  9:20 ` Lee Jones
2021-07-16  9:23   ` Matthias Schiffer
2021-07-16  9:42     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VeD4Ph_276jNQROkymTmcEXZECBY+Ci8xdGySv0fQYMXg@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bgolaszewski@baylibre.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).