From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 20/35] platform/x86/asus: Use kmemdup rather than duplicating its implementation
Date: Thu, 25 Jul 2019 20:43:43 +0300 [thread overview]
Message-ID: <CAHp75VeFrg6KwxAyMx6o46jbJ8teMMGSEckm8xM=J9kFyODQNg@mail.gmail.com> (raw)
In-Reply-To: <20190703162951.32737-1-huangfq.daxian@gmail.com>
On Wed, Jul 3, 2019 at 7:30 PM Fuqian Huang <huangfq.daxian@gmail.com> wrote:
>
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> Changes in v2:
> - Fix a typo in commit message (memset -> memcpy)
> - Split into two patches.
>
> drivers/platform/x86/asus-wmi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 9b18a184e0aa..472b317ad814 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -260,12 +260,11 @@ static int asus_wmi_evaluate_method_agfn(const struct acpi_buffer args)
> * Copy to dma capable address otherwise memory corruption occurs as
> * bios has to be able to access it.
> */
> - input.pointer = kzalloc(args.length, GFP_DMA | GFP_KERNEL);
> + input.pointer = kmemdup(args.pointer, args.length, GFP_DMA | GFP_KERNEL);
> input.length = args.length;
> if (!input.pointer)
> return -ENOMEM;
> phys_addr = virt_to_phys(input.pointer);
> - memcpy(input.pointer, args.pointer, args.length);
>
> status = asus_wmi_evaluate_method(ASUS_WMI_METHODID_AGFN,
> phys_addr, 0, &retval);
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-07-25 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 16:29 [PATCH v2 20/35] platform/x86/asus: Use kmemdup rather than duplicating its implementation Fuqian Huang
2019-07-25 17:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeFrg6KwxAyMx6o46jbJ8teMMGSEckm8xM=J9kFyODQNg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).