From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v3 10/10] serial: exar: Add support for IOT2040 device
Date: Sat, 27 May 2017 16:52:28 +0300 [thread overview]
Message-ID: <CAHp75VeH-3+k+xvMw--vk1DBtYj6Qdnczh7z77H3fboDzMScRQ@mail.gmail.com> (raw)
In-Reply-To: <8d2c0204ee4ab6040787cb953b30284940eaa2bc.1495814557.git.jan.kiszka@siemens.com>
On Fri, May 26, 2017 at 7:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This implements the setup of RS232 and the switch-over to RS485 or RS422
> for the Siemens IOT2040. That uses an EXAR XR17V352 with external logic
> to switch between the different modes. The external logic is controlled
> via MPIO pins of the EXAR controller.
>
> Only pin 10 can be exported as GPIO on the IOT2040. It is connected to
> an LED.
>
> As the XR17V352 used on the IOT2040 is not equipped with an external
> EEPROM, it cannot present itself as IOT2040-variant via subvendor/
> subdevice IDs. Thus, we have to check via DMI for the target platform.
> static void *
> -xr17v35x_register_gpio(struct pci_dev *pcidev, unsigned int first_pin,
> - unsigned int npins)
> +__xr17v35x_register_gpio(struct pci_dev *pcidev, unsigned int first_pin,
> + unsigned int npins)
> +static int xr17v35x_register_gpio(struct pci_dev *pcidev,
> + struct uart_8250_port *port)
> +{
> + if (pcidev->vendor == PCI_VENDOR_ID_EXAR)
> + port->port.private_data =
> + __xr17v35x_register_gpio(pcidev, 0, 16);
> +
> + return 0;
> +}
> - if (pcidev->vendor == PCI_VENDOR_ID_EXAR)
> - port->port.private_data =
> - xr17v35x_register_gpio(pcidev, 0, 16);
> + ret = platform->register_gpio(pcidev, port);
> }
Can't you move at least some of this to the patch where you move the check?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-05-27 13:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 16:02 [PATCH v3 00/10] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka
2017-05-26 16:02 ` [PATCH v3 01/10] serial: exar: Leave MPIOs as output for Commtech adapters Jan Kiszka
2017-05-26 16:02 ` [PATCH v3 02/10] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka
2017-05-27 13:40 ` Andy Shevchenko
2017-05-29 12:30 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 03/10] gpio-exar/8250-exar: Fix passing in of parent PCI device Jan Kiszka
2017-05-27 13:41 ` Andy Shevchenko
2017-05-29 12:31 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 04/10] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka
2017-05-29 12:32 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 05/10] gpio: exar: Fix iomap request Jan Kiszka
2017-05-29 12:32 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 06/10] gpio: exar: Fix reading of directions and values Jan Kiszka
2017-05-29 12:33 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 07/10] gpio-exar/8250-exar: Rearrange gpiochip parenthood Jan Kiszka
2017-05-27 13:43 ` Andy Shevchenko
2017-05-29 12:34 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 08/10] gpio: exar: Refactor address and bit calculations Jan Kiszka
2017-05-27 13:44 ` Andy Shevchenko
2017-05-29 12:34 ` Linus Walleij
2017-05-26 16:02 ` [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka
2017-05-27 13:48 ` Andy Shevchenko
2017-05-28 16:30 ` Jan Kiszka
2017-05-26 16:02 ` [PATCH v3 10/10] serial: exar: Add support for IOT2040 device Jan Kiszka
2017-05-27 13:52 ` Andy Shevchenko [this message]
2017-05-28 16:41 ` Jan Kiszka
2017-05-29 12:39 ` [PATCH v3 00/10] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij
2017-05-29 13:41 ` Jan Kiszka
2017-05-31 0:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeH-3+k+xvMw--vk1DBtYj6Qdnczh7z77H3fboDzMScRQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).