From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] MAX310X I2C support
Date: Mon, 6 Jun 2022 16:25:10 +0200 [thread overview]
Message-ID: <CAHp75VeHAGM=cxGRzWsv7KxUD0rjiudxOJ2HrtgtTFbuG+z8=g@mail.gmail.com> (raw)
In-Reply-To: <20220605144659.4169853-1-demonsingur@gmail.com>
On Mon, Jun 6, 2022 at 8:08 AM Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> V1 -> V2:
> * set_ext_reg_en -> extended_reg_enable
> * move extended_reg_enable functions under guards
> * move if_cfg structs under guards
> * remove __maybe_unused from max310x_i2c_driver
> * fix order of error labels in module register
> * guard i2c register error label
LGTM, thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cosmin Tanislav (4):
> serial: max310x: use regmap methods for SPI batch operations
> serial: max310x: use a separate regmap for each port
> serial: max310x: make accessing revision id interface-agnostic
> serial: max310x: implement I2C support
>
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/max310x.c | 261 ++++++++++++++++++++++++++---------
> 2 files changed, 200 insertions(+), 62 deletions(-)
>
> --
> 2.36.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-06-06 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 14:46 [PATCH v2 0/4] MAX310X I2C support Cosmin Tanislav
2022-06-05 14:46 ` [PATCH v2 1/4] serial: max310x: use regmap methods for SPI batch operations Cosmin Tanislav
2022-06-05 14:46 ` [PATCH v2 2/4] serial: max310x: use a separate regmap for each port Cosmin Tanislav
2022-06-05 14:46 ` [PATCH v2 3/4] serial: max310x: make accessing revision id interface-agnostic Cosmin Tanislav
2022-06-05 14:46 ` [PATCH v2 4/4] serial: max310x: implement I2C support Cosmin Tanislav
2022-06-06 14:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeHAGM=cxGRzWsv7KxUD0rjiudxOJ2HrtgtTFbuG+z8=g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=demonsingur@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).