From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/7] gpio: ep93xx: fix BUG_ON port F usage
Date: Tue, 9 Feb 2021 16:00:25 +0200 [thread overview]
Message-ID: <CAHp75VeLJy4zG2U2jbRnGr0f8k0F5LD_zY66W2YwJA4kC2iofQ@mail.gmail.com> (raw)
In-Reply-To: <20210209133110.7383-2-nikita.shubin@maquefel.me>
On Tue, Feb 9, 2021 at 3:31 PM Nikita Shubin <nikita.shubin@maquefel.me> wrote:
...
> + .irq = _irq, \
> .has_irq = _has_irq, \
> .has_hierarchical_irq = _has_hier, \
Just a side note for the further cleanup. No need to resend or update
right now! (of course if you or maintainers feel otherwise...)
Now you have the duplicate information, i.e. irq covers has_irq. Hence
you may drop has_irq, rename has_hierarchival_irq to
is_irq_hierarchical and update below table.
> static struct ep93xx_gpio_bank ep93xx_gpio_banks[] = {
> /* Bank A has 8 IRQs */
> - EP93XX_GPIO_BANK("A", 0x00, 0x10, 0, true, false, 64),
> + EP93XX_GPIO_BANK("A", 0x00, 0x10, 0x90, 0, true, false, 64),
> /* Bank B has 8 IRQs */
> - EP93XX_GPIO_BANK("B", 0x04, 0x14, 8, true, false, 72),
> - EP93XX_GPIO_BANK("C", 0x08, 0x18, 40, false, false, 0),
> - EP93XX_GPIO_BANK("D", 0x0c, 0x1c, 24, false, false, 0),
> - EP93XX_GPIO_BANK("E", 0x20, 0x24, 32, false, false, 0),
> + EP93XX_GPIO_BANK("B", 0x04, 0x14, 0xac, 8, true, false, 72),
> + EP93XX_GPIO_BANK("C", 0x08, 0x18, 0x00, 40, false, false, 0),
> + EP93XX_GPIO_BANK("D", 0x0c, 0x1c, 0x00, 24, false, false, 0),
> + EP93XX_GPIO_BANK("E", 0x20, 0x24, 0x00, 32, false, false, 0),
> /* Bank F has 8 IRQs */
> - EP93XX_GPIO_BANK("F", 0x30, 0x34, 16, false, true, 0),
> - EP93XX_GPIO_BANK("G", 0x38, 0x3c, 48, false, false, 0),
> - EP93XX_GPIO_BANK("H", 0x40, 0x44, 56, false, false, 0),
> + EP93XX_GPIO_BANK("F", 0x30, 0x34, 0x4c, 16, false, true, 0),
> + EP93XX_GPIO_BANK("G", 0x38, 0x3c, 0x00, 48, false, false, 0),
> + EP93XX_GPIO_BANK("H", 0x40, 0x44, 0x00, 56, false, false, 0),
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-09 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 13:31 [PATCH v6 0/7] gpio: ep93xx: fixes series patch Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 1/7] gpio: ep93xx: fix BUG_ON port F usage Nikita Shubin
2021-02-09 14:00 ` Andy Shevchenko [this message]
2021-02-09 13:31 ` [PATCH v6 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin
2021-02-09 22:03 ` Alexander Sverdlin
2021-02-09 13:31 ` [PATCH v6 3/7] gpio: ep93xx: Fix wrong irq numbers in port F Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 4/7] gpio: ep93xx: drop to_irq binding Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 5/7] gpio: ep93xx: Fix typo s/hierarchial/hierarchical Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 7/7] gpio: ep93xx: refactor base IRQ number Nikita Shubin
2021-02-09 14:02 ` [PATCH v6 0/7] gpio: ep93xx: fixes series patch Andy Shevchenko
2021-02-10 13:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeLJy4zG2U2jbRnGr0f8k0F5LD_zY66W2YwJA4kC2iofQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alexander.sverdlin@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).