From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06528C4338F for ; Mon, 16 Aug 2021 08:07:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D85FC61A60 for ; Mon, 16 Aug 2021 08:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234495AbhHPIIM (ORCPT ); Mon, 16 Aug 2021 04:08:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233182AbhHPIIK (ORCPT ); Mon, 16 Aug 2021 04:08:10 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7E41C061764; Mon, 16 Aug 2021 01:07:39 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id qe12-20020a17090b4f8c00b00179321cbae7so15540999pjb.2; Mon, 16 Aug 2021 01:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O8F6M7XCciMyzXQ0IpVQmcllwu2H30RY2XKUPdTtsxM=; b=KKxzbpgHYvBYZVkwbHROQdBJCls/Z6TZUyEUF5mjsRr6aIRAhJgXzAeE+RixnjYC4Z apCM5V48jEdJ0TUhESlbgWgRSbhVXdgRpcMOneA/tPUVG3uh/ytrrPk849hcy7k9P5aO 9uWQZppnxuPe1ThEXBY12S9HIMUthWoha1JSsd4/8nbE0lWGjDnHbgUEdNsmFHj4hBKA rZFm3nlpzxzlBC3mOpun0RTt8LshpRa9W3ZHPImAZmjtJBCPxt78sEGGIjzg/QjhPrxO FgaqKGtOlLYc+U4qF0C0bokQrRWZMEzCirRsQ/MhW5F4ltHTniyqXBDeWSq/zT+hLUdL d7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O8F6M7XCciMyzXQ0IpVQmcllwu2H30RY2XKUPdTtsxM=; b=HJM5OzcQhhB706AyyAEyhmVWc5YLiAYACxnhXOJRqnld6jYS87vDsutQeLBJpwMWxb FQmA92j5VNoDNPhrGQAQ9CbJ3u3WxnMJlPaZOBXstSPb9m5B/lkXn+jbjGnF6i8cx+78 EnKpIaQrGkRYlmPZyuu119+Ihs0LZ1ucV8W2t0/qbkXeUJLVP8lqKxcwV9hIwXSI6wjQ Zt8rOHv39oOPzDwObQsJYvgVZjejn+zb9ieMdeZ/l5Bz9iITpjYBkxoDC3sxrc3yEX3D 1NO2igm0xMK59cim6Nvj6OWzWbc+wTLDkuzWPO3PzlRXCQ2iUdbanHexhmuwNIilBhGm 5k0w== X-Gm-Message-State: AOAM531ygssqjm0h4vOrRUTooDUxIUdBflJU7G0ZAPaGst/3IlZNFj1a Lgsw4czXrYrueJcEfZPAU0P8aUUZBI7M/LU/Hk8= X-Google-Smtp-Source: ABdhPJwTmpB6MI8lz7oeijfNhU7K/Gzky9ezn1Pnsajl2Jks/HAKIPsJFFmjI78DUMzI13sVS8ysjC0ck3LmTsbCRw4= X-Received: by 2002:aa7:800b:0:b029:330:455f:57a8 with SMTP id j11-20020aa7800b0000b0290330455f57a8mr15000536pfi.7.1629101259273; Mon, 16 Aug 2021 01:07:39 -0700 (PDT) MIME-Version: 1.0 References: <20210808015659.2955443-1-liambeguin@gmail.com> <20210808015659.2955443-4-liambeguin@gmail.com> <20210808173630.5c384a4b@jic23-huawei> <20210809204253.357f97b2@jic23-huawei> In-Reply-To: From: Andy Shevchenko Date: Mon, 16 Aug 2021 11:07:00 +0300 Message-ID: Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref To: Liam Beguin Cc: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Charles-Antoine Couret , =?UTF-8?B?TnVubyBTw6E=?= , Linux Kernel Mailing List , linux-iio , devicetree , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 11:51 PM Liam Beguin wrote: > On Mon Aug 9, 2021 at 3:42 PM EDT, Jonathan Cameron wrote: ... > > > > > + /* Read channel specific information form the devicetree */ from > > > > > + device_for_each_child_node(dev, child) { > > > > > + ret = fwnode_property_read_u32(child, "reg", &i); > > > > > + if (ret) { > > > > > + dev_err(dev, "missing reg property in %pfw\n", child); > > > > > + fwnode_handle_put(child); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + ad7949_chan = &ad7949_adc->channels[i]; > > > > > + > > > > > + ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp); > > > > > + if (ret < 0 && ret != -EINVAL) { > > > > > + dev_err(dev, "invalid internal reference in %pfw\n", child); > > > > > + fwnode_handle_put(child); > > > > > + return ret; > > > > > + } > After getting access to another setup to run more tests, I noticed > that setting the reference per channel isn't really feasible. Is it a hardware limitation? -- With Best Regards, Andy Shevchenko