From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>,
Aditya Srivastava <yashsri421@gmail.com>,
industrypack-devel@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap
Date: Mon, 9 Aug 2021 21:29:30 +0300 [thread overview]
Message-ID: <CAHp75VeO31R+oYSwoFLnxtz8naK+9OrDgHagVGLrv7ARJjWfwg@mail.gmail.com> (raw)
In-Reply-To: <20210809143049.3531188-3-mudongliangabcd@gmail.com>
On Mon, Aug 9, 2021 at 5:42 PM Dongliang Mu <mudongliangabcd@gmail.com> wrote:
>
> The deallocation api for ioremap should be iounmap, other than
API
ioremap()
iounmap()
> pci_iounmap.
pci_iounmap()
Since you haven't compiled this, for the next version consider to
switch to devm_*() and pcim_*() APIs.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-09 18:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:30 [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Dongliang Mu
2021-08-09 14:30 ` [PATCH v2 2/4] ipack: tpci200: fix memory leak in the tpci200_register Dongliang Mu
2021-08-09 15:32 ` Greg Kroah-Hartman
2021-08-09 23:09 ` Dongliang Mu
2021-08-10 6:09 ` Greg Kroah-Hartman
2021-08-09 14:30 ` [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap Dongliang Mu
2021-08-09 15:33 ` Greg Kroah-Hartman
2021-08-09 18:22 ` kernel test robot
2021-08-09 18:29 ` Andy Shevchenko [this message]
2021-08-09 21:23 ` kernel test robot
2021-08-09 14:30 ` [PATCH v2 4/4] ipack: tpci200: move tpci200_unregister close to tpci200_register Dongliang Mu
2021-08-09 15:33 ` Greg Kroah-Hartman
2021-08-09 23:54 ` Dongliang Mu
2021-08-09 15:32 ` [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Greg Kroah-Hartman
2021-08-09 23:08 ` Dongliang Mu
2021-08-09 23:41 ` Dongliang Mu
2021-08-10 6:12 ` Greg Kroah-Hartman
2021-08-10 6:27 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeO31R+oYSwoFLnxtz8naK+9OrDgHagVGLrv7ARJjWfwg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=mudongliangabcd@gmail.com \
--cc=rdunlap@infradead.org \
--cc=siglesias@igalia.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).