From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Asmaa Mnebhi <asmaa@nvidia.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
David Thompson <davthompson@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] gpio: Support interrupts in gpio-mlxbf2.c
Date: Fri, 19 Mar 2021 17:44:20 +0200 [thread overview]
Message-ID: <CAHp75VePjNR8NcvHiDPuryzmxvntenUDa3OgHchoxu_4k+Nc=g@mail.gmail.com> (raw)
In-Reply-To: <YFSl0Vrh04etK28J@lunn.ch>
On Fri, Mar 19, 2021 at 3:24 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > We cannot really pass it through the ACPI table because the ACPI
> > table is common to all BlueField-2 boards. And each board may have
> > a different GPIO pin associated with a particular function. This is
> > why we use ACPI properties instead of GpioInt(). So that the
> > bootloader can change the GPIO pin value based on the board id
> > detected at boot time.
>
> That sounds very broken.
>
> ACPI describes the hardware. If the hardware is different, you need
> different ACPI. And i assume the ACPI spec says GpioInt() is the
> correct way to do this, and does not say you can hack around
> limitations of your bootloader using properties?
It seems my reply didn't make the mailing list, but I'm on the same
page with you.
On x86 boards the difference is usually provided by firmware via NVS
and corresponding macro(s).
One may google for any DSDT for x86 and check for, for instance,
GNUM() macro and Co.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-19 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1614120685-7452-1-git-send-email-Asmaa@mellanox.com>
[not found] ` <1614120685-7452-2-git-send-email-Asmaa@mellanox.com>
2021-03-02 14:02 ` [PATCH v1 1/1] gpio: Support interrupts in gpio-mlxbf2.c Linus Walleij
2021-03-02 15:26 ` Andy Shevchenko
2021-03-10 20:38 ` Asmaa Mnebhi
2021-03-19 12:53 ` Asmaa Mnebhi
2021-03-19 13:23 ` Andrew Lunn
2021-03-19 15:44 ` Andy Shevchenko [this message]
2021-03-22 12:41 ` Linus Walleij
2021-03-22 12:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VePjNR8NcvHiDPuryzmxvntenUDa3OgHchoxu_4k+Nc=g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=asmaa@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=davthompson@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).