From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08CEC2D0EB for ; Sun, 29 Mar 2020 11:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B842076A for ; Sun, 29 Mar 2020 11:22:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q/OHEu1h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgC2LW0 (ORCPT ); Sun, 29 Mar 2020 07:22:26 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46314 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728070AbgC2LW0 (ORCPT ); Sun, 29 Mar 2020 07:22:26 -0400 Received: by mail-pg1-f193.google.com with SMTP id k191so7217702pgc.13; Sun, 29 Mar 2020 04:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GMN72kZ+dQBIE9BK5gK8is5DfX56QN4AerLjDwscHk0=; b=q/OHEu1huh69xufvD4/e6DgSXihaH27aM7Fi7rji/CBHrZB5nhe28g7vKTQSJ6Tuuq eNrTJSmg0Zttdzil6nDKEenb7+1r+HwkuSbmzytcybRkQsiFOxcS8FTS1EzZoss7YSw4 9n6dLN7TMT2czm097pK6hQ0kJtyYc4LfYCPvbWGWg708YeBfg1Oq3T9rB1HjsODJzseb H1syhjFExGnlXsOyWBGBhZLjAL3DdUKTu3rUoeap1tJ5zkU9hUzbbwIM7+2NLhCXMvxr zUwMw1sqX3TGaUMO+YtQ41EOT/s4q3B6HUfcIsDJpgeSg93l3HtSxvxDxG7+WwajBc1j WCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GMN72kZ+dQBIE9BK5gK8is5DfX56QN4AerLjDwscHk0=; b=aa7wPYsbCqJO8nHorslY6epClbb6wtM+h+zi+txTG2KNT+Q+s32HTGmhb3TEPdtGY0 7KnIRaWt0gp0OuK2TXfEwW//GUdI0x9Tv8ieC05pUWLVYtmeIwzEcvrdcbjdt7KuCraI fIZjr8fMU24WPKc/IfjO+/vKEs88GtVQ3yYP3OKlL1qNeiRyV3LKWZIwj+d/FpcSnxBO tUgjMMrnP0Kfn+YjzuabY76Na4LmSus3JZ75FD8APVKAIPnQ/liyEgepffg3rqnQLUBL QEpunYAUhCJzf+6FLlQTc9vkSKdE+6P3buz5p6kks9MISJNNydmX3QedgopL8udMuFyA Q0Hg== X-Gm-Message-State: ANhLgQ3/CUjQ99Qj/hE/G0B3B9gLLGFRaaJe/MxHPQo3eIMMXfdJfuR/ KN9LSdu1ivbtXbUAy1H5sBjz9cMRZpGTSsy+QYc= X-Google-Smtp-Source: ADFU+vvo6yPjelxmVNaAJIY9eDDVqjrsR5UqyUcKJbl7RJRaA4yprdi6TnUllj58+cV++aYcvwMR9aAi4ZXZr2F1cP0= X-Received: by 2002:a05:6a00:2b4:: with SMTP id q20mr8360593pfs.36.1585480943579; Sun, 29 Mar 2020 04:22:23 -0700 (PDT) MIME-Version: 1.0 References: <20200327223443.6006-1-gwendal@chromium.org> <20200327223443.6006-13-gwendal@chromium.org> In-Reply-To: <20200327223443.6006-13-gwendal@chromium.org> From: Andy Shevchenko Date: Sun, 29 Mar 2020 14:22:11 +0300 Message-ID: Subject: Re: [PATCH v7 12/12] iio: cros_ec: flush as hwfifo attribute To: Gwendal Grignou Cc: Benson Leung , Enric Balletbo i Serra , Jonathan Cameron , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 28, 2020 at 12:37 AM Gwendal Grignou wrote: > > Add buffer/hwfifo_flush. It is not part of the ABI, but it follows ST > and HID lead: Tells the sensor hub to send to the host all pending > sensor events. I see where discussion is going, but nevertheless some comments below that you will not make same mistakes in the future. ... > + int ret = 0; Useless assignment. > + bool flush; > + > + ret = strtobool(buf, &flush); kstrtobool() > + if (ret < 0) Positive error codes? I'm not sure it returns a such. So ' < 0' part is redundant. > + return ret; > + if (!flush) > + return -EINVAL; This I didn't get, you have accept only true as input? It's really strange. > + ret = cros_ec_motion_send_host_cmd(st, 0); > + if (ret != 0) Similar to above ' != 0' part is redundant. > + dev_warn(&indio_dev->dev, "Unable to flush sensor\n"); ... > +static IIO_DEVICE_ATTR(hwfifo_flush, 0644, NULL, > + cros_ec_sensors_flush, 0); IIO_DEVICE_ATTR_RW() ? -- With Best Regards, Andy Shevchenko