From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rhys Kidd <rhyskidd@gmail.com>
Cc: "Matthew Garrett" <mjg59@google.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN
Date: Thu, 25 Jul 2019 20:59:24 +0300 [thread overview]
Message-ID: <CAHp75VeWw1rHRO+BBpr4-cyMnptF0QYkX4RQ_PUxDjVnEoV99g@mail.gmail.com> (raw)
In-Reply-To: <20190724081415.8926-1-rhyskidd@gmail.com>
On Wed, Jul 24, 2019 at 11:14 AM Rhys Kidd <rhyskidd@gmail.com> wrote:
>
> There's a wmi event generated by dell-wmi when pressing keyboard backlight
> toggle key:
> [1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed
>
> This event is for notification purposes, let's ignore it.
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/platform/x86/dell-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 1f565fb69098..ae331ac119a1 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
>
> /* Keyboard backlight level changed */
> { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
> + { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
> { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-07-25 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:14 [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Rhys Kidd
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-24 8:14 ` [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-25 17:59 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeWw1rHRO+BBpr4-cyMnptF0QYkX4RQ_PUxDjVnEoV99g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rhyskidd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).