From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C3BC432C3 for ; Tue, 19 Nov 2019 12:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C8B421D7B for ; Tue, 19 Nov 2019 12:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ltSecJN5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727948AbfKSMjE (ORCPT ); Tue, 19 Nov 2019 07:39:04 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42252 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbfKSMjD (ORCPT ); Tue, 19 Nov 2019 07:39:03 -0500 Received: by mail-pl1-f195.google.com with SMTP id j12so11699039plt.9; Tue, 19 Nov 2019 04:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qpwNQdLDEKp3mHj6bhdJa/Rq4oFAWkNqox9VT/5kxaE=; b=ltSecJN5dv6Eibo6pRLuD+iAe9yVQaHC4TL5a/T/Hp7KM4+GTbSEzMBUlRBFPT3Lpa 6HYEE3iYly2QjLrr/CEW/l0f+qZaxMuhIRvTMR6xK28UW2aWNnS0Bp1Drdj1WMQR5t5T OKMkdRURBZ1z4kOSxCPt8gkW2qo0vnUbLQzLNq8rRdnTgYbprZkfUOOOnm2p2A7EF6wE sHfG/BAOBc1uz9plhJm+pw3/GvLUKfu4zB4N6QB5+TmJKbRicc4psQtOVStnO7KxXFAt nHQUFoj3buSHslm/eRzFaHvhxZVMyZVwFhBhO0tfGl449RToViaFGi1gGPr0v20curZJ yTWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qpwNQdLDEKp3mHj6bhdJa/Rq4oFAWkNqox9VT/5kxaE=; b=alWbt0rzY0dv4gh11HzgUIuf7BlbDlww27faFJN9spvrLNBjHe761N9oyTqH7SPgaJ mlo4BnPImIJKLHfwmlY4BjW2HbLNCKL1Oh2i936AsUKgCGSkRMOsOpgdMn4luxDJGDB0 u4TuDz30LV39xw7/hWHuyW2h7zTnOSDigpPDYxB4G61iVi9RV9pdrv/xBNNsNMKNqIb/ qUu2D5Bwk3rasghVh43TP5yIqyLJCXxAH42oPj+BmrcOLc5pORv0CefVzFR27kladYAr t3osYsXLd5Bn8MbTEemZl/rBmAdPdhMaPly73BsuJOi2vhkTT3GohKnXm8PaKC3vIycW q7/A== X-Gm-Message-State: APjAAAVv6E4kc4CVL2T8YOTThV57KkXdkEe1y55TlcygngtTwX4Ur5ts OUDQx68/I//Q+YG1UxBwF5ns7F6WyaVRAkCY4MU= X-Google-Smtp-Source: APXvYqwbCUL/eximB8mpj2VKlrZgFfSMeoldq7a7WGfu5alkQzf/cM2q5535Tqgna1MJCwUak2duJRDsdSgol0JrIKM= X-Received: by 2002:a17:90a:c68f:: with SMTP id n15mr6302731pjt.20.1574167142073; Tue, 19 Nov 2019 04:39:02 -0800 (PST) MIME-Version: 1.0 References: <20191119002121.4107-1-sean.j.christopherson@intel.com> <20191119111012.GA109842@gmail.com> <20191119120655.GA31444@gmail.com> In-Reply-To: <20191119120655.GA31444@gmail.com> From: Andy Shevchenko Date: Tue, 19 Nov 2019 14:38:51 +0200 Message-ID: Subject: Re: [PATCH] x86/platform/intel/quark: Explicitly include linux/io.h for virt_to_phys() To: Ingo Molnar Cc: Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Tony Luck , Fenghua Yu , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Steven Rostedt , Ard Biesheuvel , Darren Hart , Andy Shevchenko , Nadav Amit , "VMware, Inc." , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-ia64@vger.kernel.org, Linux Kernel Mailing List , Linux PM , linux-efi , Platform Driver , ACPI Devel Maling List , ALSA Development Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 2:07 PM Ingo Molnar wrote: > > > * Ingo Molnar wrote: > > > I've applied them to tip:WIP.core/headers as a work-in-progress tree, > > and I'm testing them on randconfigs to make sure there's no broken > > dependencies. I'll wait for the ACPI acks. > > One more fix was needed, for the intel-quark driver that is only built on > 32-bit configs: > > ==================> > From: Ingo Molnar > Date: Tue, 19 Nov 2019 12:51:56 +0100 > Subject: [PATCH] x86/platform/intel/quark: Explicitly include linux/io.h for virt_to_phys() > > Similarly to the previous patches by Sean Christopherson: > > "Through a labyrinthian sequence of includes, usage of virt_to_phys() is > dependent on the include of asm/io.h in x86's asm/realmode.h, which is > included in x86's asm/acpi.h and thus by linux/acpi.h. Explicitly > include linux/io.h to break the dependency on realmode.h so that a > future patch can remove the realmode.h include from acpi.h without > breaking the build." > LGTM, Reviewed-by: Andy Shevchenko > Cc: linux-kernel@vger.kernel.org > Cc: Sean Christopherson > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Signed-off-by: Ingo Molnar > --- > arch/x86/platform/intel-quark/imr.c | 2 ++ > arch/x86/platform/intel-quark/imr_selftest.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/arch/x86/platform/intel-quark/imr.c b/arch/x86/platform/intel-quark/imr.c > index 6dd25dc5f027..e9d97d52475e 100644 > --- a/arch/x86/platform/intel-quark/imr.c > +++ b/arch/x86/platform/intel-quark/imr.c > @@ -29,6 +29,8 @@ > #include > #include > #include > +#include A nit: perhaps put it after imr.h. > + > #include > #include > #include > diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c > index 42f879b75f9b..4307830e1b6f 100644 > --- a/arch/x86/platform/intel-quark/imr_selftest.c > +++ b/arch/x86/platform/intel-quark/imr_selftest.c > @@ -14,6 +14,8 @@ > #include > #include > #include > +#include > + > #include > #include > #include > -- With Best Regards, Andy Shevchenko