From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E266C43461 for ; Tue, 8 Sep 2020 08:48:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE37A215A4 for ; Tue, 8 Sep 2020 08:48:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DtQB0Zi8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730180AbgIHIsV (ORCPT ); Tue, 8 Sep 2020 04:48:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729550AbgIHIsM (ORCPT ); Tue, 8 Sep 2020 04:48:12 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E0A0C061573; Tue, 8 Sep 2020 01:48:12 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id n14so2452773pff.6; Tue, 08 Sep 2020 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WIilKc8voJhD6HqanhXRrbRJ65/BRRqTx9fPQ2X84aw=; b=DtQB0Zi8VPGsU9ZAdMtlxkJCMDrklHDXIioGjOdUl/k01/kYRbapRmv7/mCfqa5ZHq LVeMjiDoYdZ0dE1D6kXGHDjnoLw08ELYqOKARUTg60IGXSvToqd4oXCirspt2nlbTdHR 9sl+fjC/1tFjTgZrumKMTja5vQS1+68FA8OauxUgyi4BSDLct91TGdlUpBd+nYY7STqb TnFPEGLvCFUPEdH6dEwJrbkSdHkJdy61xkL5qc/wJqyh89IcLRFdkuIgu1jLDgUFViu5 XCufnUxY0/pMxOOPXa0yKqony8olavXMOYwF5lByif2GrkCu+yQpd/CSotjAY2xrtliX 8meQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WIilKc8voJhD6HqanhXRrbRJ65/BRRqTx9fPQ2X84aw=; b=F4iRLxeEzXyOsNY7GFTD7yU4psZbaHbhrbllZJ8dp6OX5uQaCiRlGqA3lZcViQixkk 4kkvs6ctq/28PDCv5FX2bNZZDmXYsV33mvmXx72Qhk3sfT+M2/4rRt6itdrO+ZPiWYQq sn5Y1DbmsTsKFXpBbTmx291+vY2ZMaojuyStabmGLxO3a3fuJQAi6xfK2iRZkqv7tNGi p6W15zo0OdGVXyhiQmwXIwVhlw3Vc0GOegSozU7xYygYsvEgU90DDDRlKA5nfSewHmPq WGigk7K9KzdOe5ZYBsEPURelmV32ayat/aPRg3zR0UB1HL/6TxMWnL4epbzTHMCd644z QV7g== X-Gm-Message-State: AOAM530bHUSkQ3GB45eciPFcWG/iLpzsTFSql/U4uOz+lRn3s2eDmzSm chgDP6iHjveXEX571r7/Ma/l6mxGa6a3pXWDP0M= X-Google-Smtp-Source: ABdhPJwRuR5MsOCJy67DoZUhY4YMRXetafBxDeFh+WzwRES/sWLA4/43R1Up45IAx7gKq8+np9lhqvh3NtmziG0OdOo= X-Received: by 2002:a17:902:28:: with SMTP id 37mr23494899pla.107.1599554892083; Tue, 08 Sep 2020 01:48:12 -0700 (PDT) MIME-Version: 1.0 References: <20200905133230.1014581-1-j.neuschaefer@gmx.net> <20200905133230.1014581-6-j.neuschaefer@gmx.net> <20200908081445.GC4400@dell> In-Reply-To: <20200908081445.GC4400@dell> From: Andy Shevchenko Date: Tue, 8 Sep 2020 11:47:54 +0300 Message-ID: Subject: Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in Netronix EC To: Lee Jones Cc: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , "linux-kernel@vger.kernel.org" , Rob Herring , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 8, 2020 at 11:14 AM Lee Jones wrote: > On Sat, 05 Sep 2020, Andy Shevchenko wrote: > > On Saturday, September 5, 2020, Jonathan Neusch=C3=A4fer > > wrote: ... > > > +config PWM_NTXEC > > > + tristate "Netronix embedded controller PWM support" > > > > > > > > > > > + depends on MFD_NTXEC && OF > > > > > > I don=E2=80=99t see need to reduce test coverage and use of the driver = by sticking > > with OF. Actually it=E2=80=99s not used. > > If the device is only known to boot with OF, then it's pointless > building it when !OF. No, it's not. As I pointed out the (compilation) test coverage is better. > If you want to increase test coverage enable > COMPILE_TEST instead. It is one way to achieve that, yes; depends on OF || COMPILE_TEST depends on MFD_NTXEC --=20 With Best Regards, Andy Shevchenko