From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Morris Ku <morris_ku@sunix.com>,
Debbie Liu <debbie_liu@sunix.com>
Subject: Re: [PATCH v2 1/2] serial: 8250_pci: Add support for Sunix serial boards
Date: Tue, 13 Aug 2019 11:23:35 +0300 [thread overview]
Message-ID: <CAHp75VedrnJDOoJGuYJiFAx3ODGAMFx7nTKuoErNn3NWYSn_gA@mail.gmail.com> (raw)
In-Reply-To: <20190813061228.GH6670@kroah.com>
On Tue, Aug 13, 2019 at 9:12 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Aug 13, 2019 at 12:36:40PM +0800, Kai-Heng Feng wrote:
> > at 21:18, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Fri, Aug 9, 2019 at 10:05 PM Kai-Heng Feng
> > > <kai.heng.feng@canonical.com> wrote:
> > > Can you, please, split out the Sunix quirk driver to a separate module
> > > (see examples like: 8250_exar, 8250_lpss, 8250_mid)?
> > > And then with a fewer LOCs add a new boards.
> >
> > Greg asked Sunix to use existing 8250_pci.c instead of its own module.
> > It only needs a special setup function, other parts are just 8250_pci.
>
> Agreed. And this patch is already in my tree :)
>
> If people really worry about size issues, start carving this up by
> different configuration options, or yes, split it up into tiny modules
> (but note the overhead there when things get too tiny, it's a
> diminishing return).
It's always a trade off and associative pros and cons. If Sunix is a
simple one, I tend to agree that 8250_pci is a good place. For rather
big quirk modules, like Exar one, the separate sounds better (and as
we can see from retrospective of maintenance).
>
> > Why does split them a better idea? I even think of squashing 8250_moxa into
> > 8250_pci.
>
> I would agree with you, I bet you save space if you do that.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-08-13 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 19:01 [PATCH v2 1/2] serial: 8250_pci: Add support for Sunix serial boards Kai-Heng Feng
2019-08-09 19:01 ` [PATCH v2 2/2] parport: parport_serial: Add support for Sunix Multi I/O boards Kai-Heng Feng
2019-08-10 13:18 ` [PATCH v2 1/2] serial: 8250_pci: Add support for Sunix serial boards Andy Shevchenko
2019-08-13 4:36 ` Kai-Heng Feng
2019-08-13 6:12 ` Greg Kroah-Hartman
2019-08-13 8:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VedrnJDOoJGuYJiFAx3ODGAMFx7nTKuoErNn3NWYSn_gA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=debbie_liu@sunix.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=morris_ku@sunix.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).