From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbdFCNBq (ORCPT ); Sat, 3 Jun 2017 09:01:46 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:33209 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbdFCNBn (ORCPT ); Sat, 3 Jun 2017 09:01:43 -0400 MIME-Version: 1.0 In-Reply-To: <5490d3e89249bfa9edc219ff83055ab457c8b6ea.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> References: <20170531070225.bymdhhpclidwwtpt@dell> <5490d3e89249bfa9edc219ff83055ab457c8b6ea.1496266871.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Andy Shevchenko Date: Sat, 3 Jun 2017 16:01:41 +0300 Message-ID: Subject: Re: [PATCH v5 5/8] gpio: gpio-wcove: Use first level PMIC GPIO irq To: Kuppuswamy Sathyanarayanan Cc: Alexandre Courbot , "Krogerus, Heikki" , Greg Kroah-Hartman , Linus Walleij , "edubezval@gmail.com" , "dvhart@infradead.org" , "Zhang, Rui" , Lee Jones , Andy Shevchenko , "linux-gpio@vger.kernel.org" , "linux-pm@vger.kernel.org" , USB , "linux-kernel@vger.kernel.org" , Platform Driver , Sathyanarayanan Kuppuswamy Natarajan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 1, 2017 at 1:37 AM, wrote: > From: Kuppuswamy Sathyanarayanan > > PMIC mfd driver only exports first level irq for GPIO device. > But currently we are reading the irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC GPIO irq. > Shouldn't be this squashed to patch 4? > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Linus Walleij > --- > drivers/gpio/gpio-wcove.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > Changes since v1: > * used correct mask for GPIO0 and GPIO1 interrupts > > Changes since v2: > * Rebased on top of latest release. > * Removed IRQ0 and IRQ1 mask defines. > > Changes since v3: > * None > > diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c > index 7b1bc20..bba7704 100644 > --- a/drivers/gpio/gpio-wcove.c > +++ b/drivers/gpio/gpio-wcove.c > @@ -401,7 +401,7 @@ static int wcove_gpio_probe(struct platform_device *pdev) > if (!wg) > return -ENOMEM; > > - wg->regmap_irq_chip = pmic->irq_chip_data_level2; > + wg->regmap_irq_chip = pmic->irq_chip_data; > > platform_set_drvdata(pdev, wg); > > @@ -449,6 +449,18 @@ static int wcove_gpio_probe(struct platform_device *pdev) > > gpiochip_set_nested_irqchip(&wg->chip, &wcove_irqchip, virq); > > + /* Enable GPIO0 interrupts */ > + ret = regmap_update_bits(wg->regmap, IRQ_MASK_BASE, GPIO_IRQ0_MASK, > + 0x00); > + if (ret) > + return ret; > + > + /* Enable GPIO1 interrupts */ > + ret = regmap_update_bits(wg->regmap, IRQ_MASK_BASE + 1, GPIO_IRQ1_MASK, > + 0x00); > + if (ret) > + return ret; > + > return 0; > } > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko