From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Sergey Semin <Sergey.Semin@baikalelectronics.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Barry Song <song.bao.hua@hisilicon.com>,
John Garry <john.garry@huawei.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
prime.zeng@huawei.com, Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v7 2/5] i2c: core: add api to provide frequency mode strings
Date: Fri, 9 Apr 2021 14:40:31 +0300 [thread overview]
Message-ID: <CAHp75VekZKo-45Pc7mp9Pfwzx=jS7L2SBhb564acWkuAo5cPAQ@mail.gmail.com> (raw)
In-Reply-To: <20210409113722.GB879@ninjato>
On Fri, Apr 9, 2021 at 2:37 PM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > Can we add this later if needed?
> > Because in such case additionally printing bus_freq_hz will be fine, no?
>
> Yes, we can do that.
>
> > But putting max to each frequency representation in the list of strings sounds
> > good to me.
>
> It is not important to me if we are going to change that later anyhow.
> I'll leave it to you guys.
Thanks, I think the series is okay to go as is.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-09 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 11:17 [PATCH v7 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-04-08 11:17 ` [PATCH v7 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-04-08 11:17 ` [PATCH v7 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-04-08 20:55 ` Wolfram Sang
2021-04-09 10:36 ` Andy Shevchenko
2021-04-09 11:37 ` Wolfram Sang
2021-04-09 11:40 ` Andy Shevchenko [this message]
2021-04-09 13:49 ` Yicong Yang
2021-04-08 11:17 ` [PATCH v7 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-04-08 11:17 ` [PATCH v7 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-04-08 20:57 ` Wolfram Sang
2021-04-08 11:17 ` [PATCH v7 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VekZKo-45Pc7mp9Pfwzx=jS7L2SBhb564acWkuAo5cPAQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).