From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754834AbbKCIW3 (ORCPT ); Tue, 3 Nov 2015 03:22:29 -0500 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35288 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbbKCIW0 (ORCPT ); Tue, 3 Nov 2015 03:22:26 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446444460-21600-1-git-send-email-okaya@codeaurora.org> <1446444460-21600-3-git-send-email-okaya@codeaurora.org> <20151103041528.GS21326@localhost> <5638359D.9080507@codeaurora.org> <20151103063009.GT21326@localhost> Date: Tue, 3 Nov 2015 10:22:25 +0200 Message-ID: Subject: Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions From: Andy Shevchenko To: Dan Williams Cc: Vinod Koul , Sinan Kaya , "dmaengine@vger.kernel.org" , timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 3, 2015 at 9:44 AM, Dan Williams wrote: > On Mon, Nov 2, 2015 at 10:30 PM, Vinod Koul wrote: >> On Mon, Nov 02, 2015 at 11:18:37PM -0500, Sinan Kaya wrote: >>> On 11/2/2015 11:15 PM, Vinod Koul wrote: >>> >On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote: >>> This one; on the other hand, is selftest to verify hardware is >>> working as expected during power up. I prefer to have such nice case by run time parameter (let's say common to all DMA Engine drivers) >> We can have common code which is used for dmatest as well as selftest. I do >> not want to see same code duplicated.. First thought was to merge this to dmatest, however, some DMA controllers doesn't have a memcpy capability. How would we test them? -- With Best Regards, Andy Shevchenko