From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Denis Ciocca <denis.ciocca@st.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/4] iio: st_sensors: remove all driver remove functions
Date: Mon, 26 Jul 2021 10:20:07 +0300 [thread overview]
Message-ID: <CAHp75Vem3Q5vRknvWrZSsX4_+2j7fGtU6RcLzCHEr2AA67eZfA@mail.gmail.com> (raw)
In-Reply-To: <20210726071404.14529-4-aardelean@deviqon.com>
On Mon, Jul 26, 2021 at 10:14 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> At this point all ST driver remove functions do iio_device_unregister().
> This change removes them from them and replaces all iio_device_register()
> with devm_iio_device_register().
>
> This can be done in a single change relatively easy, since all these remove
easily
> functions are define in st_sensors.h.
defined
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h | 1 -
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c | 15 +--------------
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 6 ------
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 6 ------
I will check these later on, but the rule of thumb about devm_*() is
that there shouldn't be gaps (non-devm) before any devm call.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-26 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:14 [PATCH 0/4] iio: st_sensors: convert probe functions to full devm Alexandru Ardelean
2021-07-26 7:14 ` [PATCH 1/4] iio: st_sensors: remove st_sensors_deallocate_trigger() function Alexandru Ardelean
2021-07-26 7:14 ` [PATCH 2/4] iio: st_sensors: remove st_sensors_power_disable() function Alexandru Ardelean
2021-07-31 17:37 ` Jonathan Cameron
2021-08-02 7:30 ` Alexandru Ardelean
2021-08-16 7:48 ` Alexandru Ardelean
2021-08-16 8:53 ` Jonathan Cameron
2021-07-26 7:14 ` [PATCH 3/4] iio: st_sensors: remove all driver remove functions Alexandru Ardelean
2021-07-26 7:20 ` Andy Shevchenko [this message]
2021-07-26 7:14 ` [PATCH 4/4] iio: st_sensors: remove reference to parent device object on st_sensor_data Alexandru Ardelean
2021-07-31 17:40 ` [PATCH 0/4] iio: st_sensors: convert probe functions to full devm Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vem3Q5vRknvWrZSsX4_+2j7fGtU6RcLzCHEr2AA67eZfA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=aardelean@deviqon.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).