From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAF6C19F2D for ; Sat, 6 Aug 2022 10:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241822AbiHFK2a (ORCPT ); Sat, 6 Aug 2022 06:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiHFK21 (ORCPT ); Sat, 6 Aug 2022 06:28:27 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD17613D7B; Sat, 6 Aug 2022 03:28:26 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id a2so3497220qkk.2; Sat, 06 Aug 2022 03:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=QMTcefpNaXq/ZeFIs0rURWC/eH5FulURuyF9pjeQIKg=; b=kx3fQWqCCzxht1ZQEWMZw6KT8jK3aN+7imhz+wkAU1ufYm39mo8PbvVff4cuYmqyN2 ljJ5Ll6/+wM5aBjPml+X61OOQBxumKeWliDdzQhnBk0YBlE4tQIWJ4L5OgLSEqv7b/vj W4TpOGSHDYzRueAZI1dZtODFDqSs9NYwGbKeH2vGuQjffmNU7Nu8yqNeAsM+XkZOD2px 31eTK87fGhOCwSAE+tJ8viqtIGzAS48ydY2PihiwTFCZa88gU/19B8/HsqQTBx+vB5yN bZXgIDceh1s/DbrMzR8/LNeHgBmX76FBYRNaGcx5qwXfwID8P6sNjO8a2xyKBSvoftFa pKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=QMTcefpNaXq/ZeFIs0rURWC/eH5FulURuyF9pjeQIKg=; b=GUhYbluI3u6Y47z3IUsVcKzb1noqJ1Mvq7JadZNcCEVKmNkuTNTW0LD1IRn6ns49Ut PjJDfXKohaj3mGPMWw8XeOEcmXJN1ri9izr3dKR+W+6brAAd8pJA7EhRgTBmoE0A6O8l +qganPBraWA5b+/kNDs/KsoUxxy+GbbvXgkt4Ww7+ffsmNWvxdX+8YpP2akxiWqHwYFY tohOu00WIHSpKFRmwGYojdrZJgqW7u9oQL7uusaP5uwhKcRWNyJHq0b/5H7G0pKKL8gZ ZpWyWChKPxwtmwKRybhPlhrCbf2Y/TPxdfrnww7QhiagPQ8ENXcU2EcZmt1qbsO0cBrq LNOQ== X-Gm-Message-State: ACgBeo2r1ye86t9gxQoiEbtk4gS7eAe/xABIywAyrlHklpLP+js2lxXq O8rr8JBLnRQ9ROSELVzoPgLExisjg2axIFVKMkQ= X-Google-Smtp-Source: AA6agR4Vo+KLnsEFQ2f5AtjEGGpM0ivIbO4OzSxPRY6LZS6Vrg+qaW7a5WIcasBoQG/CZhVC1u4sgwffrC/YSM/cQNI= X-Received: by 2002:a05:620a:8018:b0:6b6:5df:977 with SMTP id ee24-20020a05620a801800b006b605df0977mr7902043qkb.320.1659781705909; Sat, 06 Aug 2022 03:28:25 -0700 (PDT) MIME-Version: 1.0 References: <20220805081909.10962-1-luke@ljones.dev> <20220805081909.10962-2-luke@ljones.dev> In-Reply-To: From: Andy Shevchenko Date: Sat, 6 Aug 2022 12:27:48 +0200 Message-ID: Subject: Re: [PATCH 1/5] asus-wmi: Add basic support for TUF laptop keyboard RGB To: Luke Jones Cc: Hans de Goede , Mark Gross , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 6, 2022 at 12:27 PM Andy Shevchenko wrote: > On Sat, Aug 6, 2022 at 12:16 PM Luke Jones wrote: > > On Sat, Aug 6 2022 at 11:44:33 +0200, Andy Shevchenko > > wrote: > > > On Fri, Aug 5, 2022 at 10:20 AM Luke D. Jones wrote: ... > > >> #include > > >> +#include > > > > > > Not sure about the ordering ('-' vs. 's') in locale C. > > > > I used hid-playstation.c as a reference and followed that ordering. > > Try something like this: > > LC_ALL=c sort Should be, of course, LC_ALL=C sort > for these two lines and see if the ordering is the same. -- With Best Regards, Andy Shevchenko