From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D76C433FE for ; Fri, 11 Dec 2020 19:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6340C23ED2 for ; Fri, 11 Dec 2020 19:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393167AbgLKSNb (ORCPT ); Fri, 11 Dec 2020 13:13:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390729AbgLKSNE (ORCPT ); Fri, 11 Dec 2020 13:13:04 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68517C0613CF; Fri, 11 Dec 2020 10:12:24 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id s21so7450492pfu.13; Fri, 11 Dec 2020 10:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q/1zdMH3DpxGtZ8QgtITmolgonObU/7AjOPUuWKrWNo=; b=Pm8buLXst2LcV9x4pk4vIxyybuwSbvL97o6tQP/6i0ZC0zOJ6xhhPvOmmJHnVFkhgw sQfgcxJImHA+DnVZbZxb64zhatDbthp68cZ4iRaEqM/K8XSe9UZnfE94uYtkDbOOpabu L1rj/JPmJET4DAk/lcrawpEkrx9i3ul2i6qGlaQuFoK2UkPf+SMWdOeOPPS8QAdKSG2Q g24KIZVw1nm3kfJCayecl50J7bltlRshvQcWiGMUSmazoa8KfAW/iwqyejRvRxGzsh3A q/OBzRHzggVvK36H+lQNs9ICk+Z16dfzwLBUVGvlOwEUqmBMnCQtHV8wDQuwIxn+Jo8v 0Yfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q/1zdMH3DpxGtZ8QgtITmolgonObU/7AjOPUuWKrWNo=; b=EUUxuVDwUWkj1VArEtjSBAzqeN4Wr6zM05G+Q3mhyiAFFwoot0Tjkm3KXPYozOD/xr 86NeIsAM8IDCmetb9oFwO7zyiphFE5DUt4+ORhznegIu4TRh0WU0TlpNEK+cgdNJNkmI B1zK7w2FH1XQwMIOHWK4VsMbpXa803wM+hRRf0Y8QGQpHZOT8svJNXzrm+UDXHM/4gLw UMMLOsnR1opUvQ27r5JYsBE09ElPEDJej9h2Rtb7vEP07p40Ol0yHrsfc/+JTjfU4Xpo zSsGg2zHm4ifwozvvG1U+BS9+++ABI5xWdVi7CuzGpqAZyBB7erM/tgI3wpkUwrJiynZ 72Ng== X-Gm-Message-State: AOAM530wzfZyvYP8kvZQqBiDlVHVmCQaNvNQShgjEYbz+ZgL6ANmMuCa 6AQKarhTbx0Jga4itoXmo5MQmDtx31BldQk7wZeN5o4nx2lt2mU9 X-Google-Smtp-Source: ABdhPJzPNFm8swDHOmLl35eT5h+YQB676NTtT2BWFgfALxfYZ8r2UnWa+iJwNQSLiKZOMQcPIak2nNSo7eC4Ue1vtXA= X-Received: by 2002:a63:4002:: with SMTP id n2mr13054398pga.4.1607710343875; Fri, 11 Dec 2020 10:12:23 -0800 (PST) MIME-Version: 1.0 References: <20201210192536.118432146@linutronix.de> <20201210194044.157283633@linutronix.de> In-Reply-To: <20201210194044.157283633@linutronix.de> From: Andy Shevchenko Date: Fri, 11 Dec 2020 20:12:07 +0200 Message-ID: Subject: Re: [patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Marc Zyngier , Linus Walleij , Lee Jones , linux-arm Mailing List , "James E.J. Bottomley" , Helge Deller , afzal mohammed , linux-parisc@vger.kernel.org, Russell King , Mark Rutland , Catalin Marinas , Will Deacon , Christian Borntraeger , Heiko Carstens , linux-s390@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Pankaj Bharadiya , Chris Wilson , Wambui Karuga , intel-gfx , dri-devel , Tvrtko Ursulin , "open list:GPIO SUBSYSTEM" , Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Michal Simek , linux-pci , Karthikeyan Mitran , Hou Zhiqiang , Tariq Toukan , "David S. Miller" , Jakub Kicinski , netdev , "open list:HFI1 DRIVER" , Saeed Mahameed , Leon Romanovsky , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 9:57 PM Thomas Gleixner wrote: > > First of all drivers have absolutely no business to dig into the internals > of an irq descriptor. That's core code and subject to change. All of this > information is readily available to /proc/interrupts in a safe and race > free way. > > Remove the inspection code which is a blatant violation of subsystem > boundaries and racy against concurrent modifications of the interrupt > descriptor. > > Print the irq line instead so the information can be looked up in a sane > way in /proc/interrupts. ... > - seq_printf(s, "%3i: %6i %4i", > + seq_printf(s, "%3i: %6i %4i %4i\n", Seems different specifiers, I think the intention was something like seq_printf(s, "%3i: %4i %6i %4i\n", > line, > + line + irq_first, > num_interrupts[line], > num_wake_interrupts[line]); -- With Best Regards, Andy Shevchenko