From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: mapengyu@gmail.com,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Thinkpad-acpi devel ML <ibm-acpi-devel@lists.sourceforge.net>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid
Date: Thu, 2 Jul 2020 13:59:31 +0300 [thread overview]
Message-ID: <CAHp75Veqp_saX+VsijpLrihKMHiVH1W4o-3CYXNooOCu=YKtjA@mail.gmail.com> (raw)
In-Reply-To: <2ecf4032-267c-32c8-361f-2396730aaa65@canonical.com>
On Thu, Jul 2, 2020 at 1:51 PM Aaron Ma <aaron.ma@canonical.com> wrote:
> On 7/2/20 5:30 PM, Andy Shevchenko wrote:
> > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@canonical.com> wrote:
> >>
> >> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
> >>
> >> brightness_enable is already checked at the beginning,
> >
> >> Always print notice when enabled brightness control.
> >
> > Why?
> >
>
> Default brightness_enable = 2, so this message will always be printed as before
> Actually no change here.
>
> > ...
> >
> >> + pr_notice("thinkpad_acpi native brightness control enabled\n");
> >
> > 'notice' level is quite high, why do we spam users with this?
> >
>
> Like above.
>
> Another reason is most thinkpads are using native gpu driver to control
> brightness, notice when thinkpad_acpi brightness is enabled.
So, based on the above, please elaborate and explain all this in the
commit message of new version, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-02 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 8:55 [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid Aaron Ma
2020-07-02 9:30 ` Andy Shevchenko
2020-07-02 10:51 ` Aaron Ma
2020-07-02 10:59 ` Andy Shevchenko [this message]
2020-07-02 11:07 ` [v2][PATCH] " Aaron Ma
2020-07-09 18:31 ` Andy Shevchenko
2020-07-10 1:56 ` [v3][PATCH] " Aaron Ma
2020-07-10 20:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Veqp_saX+VsijpLrihKMHiVH1W4o-3CYXNooOCu=YKtjA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=aaron.ma@canonical.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mapengyu@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).