Re: [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkill()

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
	Darren Hart <dvhart@infradead.org>,
	Marco Chiappero <marco@absence.it>,
	Mattia Dongili <malattia@linux.it>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v2 2/3] Sony-laptop: Delete an unnecessary variable initialisation in sony_nc_setup_rfkill()
Date: Fri, 3 Nov 2017 14:00:32 +0200	[thread overview]
Message-ID: <CAHp75VeqvKHLiSSdQGYLjBdqdPcFt7gaeKpXpWCtFv93ZaR1sg@mail.gmail.com> (raw)
In-Reply-To: <3bc1148d-01e1-11fe-1594-1c7ffd83600f@users.sourceforge.net>

On Wed, Nov 1, 2017 at 8:47 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 1 Nov 2017 19:00:59 +0100
>
> The local variable "err" will eventually be set to an appropriate value
> a bit later. Thus omit the explicit initialisation at the beginning.

Applied to my review and testing queue, thanks!

>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/platform/x86/sony-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 4332cc982ce0..62aa2c37b8d2 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -1627,7 +1627,7 @@ static const struct rfkill_ops sony_rfkill_ops = {
>  static int sony_nc_setup_rfkill(struct acpi_device *device,
>                                 enum sony_nc_rfkill nc_type)
>  {
> -       int err = 0;
> +       int err;
>         struct rfkill *rfk;
>         enum rfkill_type type;
>         const char *name;
> --
> 2.14.3
>

-- 
With Best Regards,
Andy Shevchenko