From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S638216AbdDZOwN (ORCPT ); Wed, 26 Apr 2017 10:52:13 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:34171 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1955639AbdDZOwL (ORCPT ); Wed, 26 Apr 2017 10:52:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <3257d22879148692da6887f89843389bd37ee877.1493060870.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Andy Shevchenko Date: Wed, 26 Apr 2017 17:52:09 +0300 Message-ID: Subject: Re: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask To: Linus Walleij Cc: Kuppuswamy Sathyanarayanan , Bin Gao , Mika Westerberg , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sathyanarayanan Kuppuswamy Natarajan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 26, 2017 at 5:26 PM, Linus Walleij wrote: > On Mon, Apr 24, 2017 at 9:15 PM, > wrote: > >> From: Kuppuswamy Sathyanarayanan >> >> According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to >> battery IO. So we should skip this bit when checking for GPIO IRQ pending >> status. Otherwise, wcove_gpio_irq_handler() might go into the infinite >> loop until IRQ "pending" status becomes 0. This patch fixes this issue. >> >> Signed-off-by: Kuppuswamy Sathyanarayanan > > Looks fine to me, tentatively applied. > > Bin, Mika, Andy, OK? Yes, thanks! -- With Best Regards, Andy Shevchenko