From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21524ECE58C for ; Fri, 11 Oct 2019 09:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE1312084C for ; Fri, 11 Oct 2019 09:05:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgaN4KE7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727515AbfJKJFN (ORCPT ); Fri, 11 Oct 2019 05:05:13 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44401 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbfJKJFM (ORCPT ); Fri, 11 Oct 2019 05:05:12 -0400 Received: by mail-pl1-f196.google.com with SMTP id q15so4160008pll.11; Fri, 11 Oct 2019 02:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPcuPeIlGeOi9YaKxS0E+IUcP4UClOCoB6akqo9MA54=; b=sgaN4KE7J6nZ1zyZAXZdmNnMCJvCdAf1A9dZTN75N71vjZozqgVkF6SRCgwAlsp4QD 8XWapee9vlLUR7jMvU+ZgVJTqhlijr7ODzf03Fl0COjniRsj/oazOw10D4SSea4KpXB3 R9e6V8EG+vKLDiRYT/2AXS5bHbocBAhnGzWP4bdjedIRZG14P7KEvGWDPy07kRKJrBzZ uM4OdbNzf5RlH2/C03woRXD7hg8MPZGXLj5BGUJb3gnSW9UmHYRwpkNYpWx/QsvJLk4o hiC3F6G7R4Q8nfi3Ry5tgWmBqGZhD8Hg02FaRW90wkFOvFGpNgibktw8SCSWcyjWlGO6 5Gqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPcuPeIlGeOi9YaKxS0E+IUcP4UClOCoB6akqo9MA54=; b=Pz5BeG1B3CSZv6ZQiJJDrUegDeo9p/vyBsZ+7/m7jVB8ByQR8doi6LA5N6qF5hhKs9 hJ5b0m1UsNIiYOgLILKRf87BeZZIbhfjlKvzRdbgMBrksq+GFMaXiZv545GZ91tdw//+ JhmlKfIJ2YAHeFnRvhLShheOFTeKSyTPISKEze0zHdIMIKx5b4DbP4OfovezGLYyhDkI HSbZb9sv3FRJglr3DvLFNwy+x6R/7aAaKXUK3G4Djob/yUgX9stKMl/hAEsUylE0RwiW xdluOQXTCwTuAdZfw2qbD+wUF6hdm8UxYksh2Oj8XVUaTo/p3TC/h4/kmUk0SZLfV4Ap 7RjA== X-Gm-Message-State: APjAAAWGVwIkWqK/zV95Z9dAeRxwoPBCBE3lZKBgi/SCMPkbuuD1bE+y MRMPA5u6lQgVwIN0GLc1t8tyCMgAvAnzTIoBBAE= X-Google-Smtp-Source: APXvYqxbzxppCszYm0qJzDIQnxj+XzuVTYxiUW4vwnqwrnlvr31HA/eEjVaDVkHfEVYX3aAUVyrO0WzYtlrASSdeU5Y= X-Received: by 2002:a17:902:b110:: with SMTP id q16mr13678309plr.262.1570784711945; Fri, 11 Oct 2019 02:05:11 -0700 (PDT) MIME-Version: 1.0 References: <20191009200523.8436-1-stuart.w.hayes@gmail.com> <20191009200523.8436-3-stuart.w.hayes@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 11 Oct 2019 12:05:01 +0300 Message-ID: Subject: Re: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled To: Stuart Hayes Cc: Bjorn Helgaas , Austin Bolen , Keith Busch , Alexandru Gagniuc , "Rafael J . Wysocki" , Mika Westerberg , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Lukas Wunner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 11:48 AM Andy Shevchenko wrote: > > On Fri, Oct 11, 2019 at 9:49 AM Andy Shevchenko > wrote: > > > > On Thu, Oct 10, 2019 at 11:37 PM Stuart Hayes wrote: > > > > > Thank you for the feedback! An infinite loop is used several other places in > > > this driver--this keeps the style similar. I can change it as you suggest, > > > though, if that would be preferable to consistency. > > > > Better to start the change now. I'll look into the file and see how we > > can improve the rest. > > I found only one infinite loop there, the other timeout loop is done > as do {} while. > I'll send a patch to refactor the infinite one. https://lore.kernel.org/linux-pci/20191011090230.81080-1-andriy.shevchenko@linux.intel.com/T/#u -- With Best Regards, Andy Shevchenko