linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: Andy Shevchenko <andy@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH platform-next v1 2/9] Documentation/ABI: Fix attributes for mlxreg-io sysfs interfaces
Date: Thu, 9 Jan 2020 17:14:18 +0200	[thread overview]
Message-ID: <CAHp75Veu7PhR0FiufXM2R=dU4vLmeL5sf3kuVi2g=NZSw3L6OA@mail.gmail.com> (raw)
In-Reply-To: <20191231102917.24181-3-vadimp@mellanox.com>

On Tue, Dec 31, 2019 at 12:29 PM Vadim Pasternak <vadimp@mellanox.com> wrote:
>
> Fix attribute name from "jtag_enable" to "cpld3_version" and
> extend description for "cpld3_version" attribute.
>
> Add missed "cpld4_version" attribute.
>

From this commit message it's still unclear if we have had the ABI
change or Documentation inconsistency.

> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
>  Documentation/ABI/stable/sysfs-driver-mlxreg-io | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> index 8ca498447aeb..fe30fe505c9b 100644
> --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> @@ -29,13 +29,13 @@ Description:        This file shows the system fans direction:
>
>                 The files are read only.
>
> -What:          /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/jtag_enable
> +What:          /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld3_version
>
>  Date:          November 2018
>  KernelVersion: 5.0
>  Contact:       Vadim Pasternak <vadimpmellanox.com>
>  Description:   These files show with which CPLD versions have been burned
> -               on LED board.
> +               on LED or Gearbox board.
>
>                 The files are read only.
>
> @@ -121,6 +121,16 @@ Description:       These files show the system reset cause, as following: ComEx
>
>                 The files are read only.
>
> +What:          /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld4_version
> +
> +Date:          November 2018
> +KernelVersion: 5.0
> +Contact:       Vadim Pasternak <vadimpmellanox.com>
> +Description:   These files show with which CPLD versions have been burned
> +               on LED board.
> +
> +               The files are read only.
> +
>  Date:          June 2019
>  KernelVersion: 5.3
>  Contact:       Vadim Pasternak <vadimpmellanox.com>
> --
> 2.11.0
>


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2020-01-09 15:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31 10:29 [PATCH platform-next v1 0/9] platform/x86: Mellanox new system classes and new features Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 1/9] platform/x86: mlx-platform: Add more definitions for system attributes Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 2/9] Documentation/ABI: Fix attributes for mlxreg-io sysfs interfaces Vadim Pasternak
2020-01-09 15:14   ` Andy Shevchenko [this message]
2019-12-31 10:29 ` [PATCH platform-next v1 3/9] Documentation/ABI: Add new attribute " Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 4/9] platform/x86: mlx-platform: Cosmetic changes Vadim Pasternak
2020-01-09 15:16   ` Andy Shevchenko
2019-12-31 10:29 ` [PATCH platform-next v1 5/9] platform/x86: mlx-platform: Set system mux configuration based on system type Vadim Pasternak
2020-01-09 15:19   ` Andy Shevchenko
2019-12-31 10:29 ` [PATCH platform-next v1 6/9] platform/x86: mlx-platform: Add support for new " Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 7/9] platform/x86: mlx-platform: Add support for new capability register Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 8/9] platform/mellanox: mlxreg-hotplug: " Vadim Pasternak
2019-12-31 10:29 ` [PATCH platform-next v1 9/9] platform/x86: mlx-platform: Add support for next generation systems Vadim Pasternak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Veu7PhR0FiufXM2R=dU4vLmeL5sf3kuVi2g=NZSw3L6OA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vadimp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).