From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbcLCMl5 (ORCPT ); Sat, 3 Dec 2016 07:41:57 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36452 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbcLCMlz (ORCPT ); Sat, 3 Dec 2016 07:41:55 -0500 MIME-Version: 1.0 In-Reply-To: References: <1469728428-24881-1-git-send-email-mario_limonciello@dell.com> <1469728428-24881-2-git-send-email-mario_limonciello@dell.com> From: Andy Shevchenko Date: Sat, 3 Dec 2016 14:41:54 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s To: Mario Limonciello , Dmitry Torokhov Cc: "dvhart@infradead.org" , LKML , platform-driver-x86@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko wrote: > On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello > wrote: >> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3) >> and a detachable keyboard/mouse dock. >> >> Signed-off-by: Mario Limonciello > > There was a long discussion in the past. Just to get it clear. Are we > all okay with version 2 of this series? Darren, FWIW: Reviewed-by: Andy Shevchenko > >> --- >> drivers/platform/x86/dell-wmi.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c >> index 866bf73..28ec17a 100644 >> --- a/drivers/platform/x86/dell-wmi.c >> +++ b/drivers/platform/x86/dell-wmi.c >> @@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = { >> >> /* Stealth mode toggle */ >> { KE_IGNORE, 0x155, { KEY_RESERVED } }, >> + >> + /* Rugged magnetic dock attach/detach events */ >> + { KE_IGNORE, 0x156, { KEY_RESERVED } }, >> + { KE_IGNORE, 0x157, { KEY_RESERVED } }, >> + >> + /* Rugged programmable (P1/P2/P3 keys) */ >> + { KE_KEY, 0x850, { KEY_PROG1 } }, >> + { KE_KEY, 0x851, { KEY_PROG2 } }, >> + { KE_KEY, 0x852, { KEY_PROG3 } }, >> + >> }; -- With Best Regards, Andy Shevchenko