From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v1 1/1] PCI: keystone: Use device_get_match_data()
Date: Wed, 28 Jul 2021 19:03:18 +0300 [thread overview]
Message-ID: <CAHp75Vex4NffM_H0sK8LnyauMizmk3CjhKYurrcm==80K+qQ-Q@mail.gmail.com> (raw)
In-Reply-To: <20210728155002.GA822338@bjorn-Precision-5520>
On Wed, Jul 28, 2021 at 6:51 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Wed, Jul 28, 2021 at 01:55:58PM +0300, Andy Shevchenko wrote:
> > Instead of manipulations with OF APIs, use device_get_match_data().
> >
> > While at it, drop of_match_ptr() completely and make compiler happy,
> > otherwise it complains:
> >
> > pci-keystone.c:1069:34: warning: ‘ks_pcie_of_match’ defined but not used [-Wunused-const-variable=]
>
> These are two separate things and I'd prefer two separate patches.
>
> I have a to-do item on my list to replace of_match_device(), as you
> did here. I originally suggested replacing with
> device_get_match_data(), but I think Rob prefers
> of_device_get_match_data() because there's really no benefit to the
> extra indirection of device_get_match_data(). These are not drivers
> that may potentially be used with either ACPI or OF; they're just OF.
>
> Either way, I'd like to see a patch that does this for all drivers in
> drivers/pci/controller/ at the same time so they get slightly more
> consistent.
>
> Same for the .of_match_table update; a good change that I'd like to
> apply universally. It looks like pcie-spear13xx.c, pcie-armada8k.c,
> pci-ftpci100.c, pci-v3-semi.c, pci-xgene.c, pcie-iproc-platform.c also
> have the same issue.
Thanks for the review, I will drop this.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-28 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 10:55 [PATCH v1 1/1] PCI: keystone: Use device_get_match_data() Andy Shevchenko
2021-07-28 15:50 ` Bjorn Helgaas
2021-07-28 16:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vex4NffM_H0sK8LnyauMizmk3CjhKYurrcm==80K+qQ-Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).