From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Peter Rosin <peda@axentia.se>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
刘炜 <liuwei@actions-semi.com>,
mp-cs@actions-semi.com, 96boards@ucrobotics.com,
devicetree <devicetree@vger.kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
amit.kucheria@linaro.org,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
hzhang@ucrobotics.com, bdong@ucrobotics.com,
"Mani Sadhasivam" <manivannanece23@gmail.com>,
"Thomas Liau" <thomas.liau@actions-semi.com>,
jeff.chen@actions-semi.com
Subject: Re: [PATCH v6 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver
Date: Mon, 23 Jul 2018 10:24:58 +0300 [thread overview]
Message-ID: <CAHp75Vf+SLQERDhDGRE-J_hmWwniiHN0FALbaBQjBY4GRNV_Fw@mail.gmail.com> (raw)
In-Reply-To: <911dc259-7b30-9c6e-2c82-2f4c032b9d73@axentia.se>
On Mon, Jul 23, 2018 at 9:12 AM, Peter Rosin <peda@axentia.se> wrote:
> On 2018-07-23 05:40, Manivannan Sadhasivam wrote:
>> + /* Handle the remaining bytes which were not sent */
>> + while (!(readl(i2c_dev->base + OWL_I2C_REG_FIFOSTAT) &
>> + OWL_I2C_FIFOSTAT_TFF) && i2c_dev->msg_ptr < msg->len) {
>
> You moved the OWL_ line to the left instead of right, so this is still
> misaligned and thus not helping the reader.
Guys, wouldn't be better to
while (i2c_dev->msg_ptr < msg->len) {
u32 fifostat = readl();
if (!(fifostat & ...))
break;
...
}
?
Same for the other branch.
Yes, it's more LOCs, but less bikeshedding,
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-07-23 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 3:40 [PATCH v6 0/6] Add Actions Semiconductor Owl S900 I2C support Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 1/6] dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 2/6] arm64: dts: actions: Add pinctrl definition for S900 " Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 3/6] arm64: dts: actions: Add Actions Semiconductor S900 I2C controller nodes Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 4/6] arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board Manivannan Sadhasivam
2018-07-23 3:40 ` [PATCH v6 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver Manivannan Sadhasivam
2018-07-23 6:12 ` Peter Rosin
2018-07-23 7:24 ` Manivannan Sadhasivam
2018-07-23 7:24 ` Andy Shevchenko [this message]
2018-07-23 7:40 ` Peter Rosin
2018-07-23 3:40 ` [PATCH v6 6/6] MAINTAINERS: Add entry for Actions Semiconductor Owl " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf+SLQERDhDGRE-J_hmWwniiHN0FALbaBQjBY4GRNV_Fw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=96boards@ucrobotics.com \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=bdong@ucrobotics.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hzhang@ucrobotics.com \
--cc=jeff.chen@actions-semi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=manivannanece23@gmail.com \
--cc=mp-cs@actions-semi.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=thomas.liau@actions-semi.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).