From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD202C07E9A for ; Mon, 5 Jul 2021 08:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4D51613C2 for ; Mon, 5 Jul 2021 08:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbhGEIsi (ORCPT ); Mon, 5 Jul 2021 04:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbhGEIsg (ORCPT ); Mon, 5 Jul 2021 04:48:36 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 546F9C061574; Mon, 5 Jul 2021 01:46:00 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id h6so8745976plf.11; Mon, 05 Jul 2021 01:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6tzBQn21ISHfDplCImGeslYtqyN4YOQPVRToQhASUVY=; b=lsyuPfdJN1JWMUyysgrmTUfLuyr+r0n/yyXQm8uXA8jGs2fsp5d4/xg38840DuDWnP dNwFse8mYFi+94lzCONUh+VbsDypmP81Gh2xIx/jklcTzT0DJbocwiXiasCTWRv9h3Fs Qsu0ukBiK1gHvejWCW+J4KessUsdPdovGVfQSfGAW6fuAAl5ooVWYkpdMxDhNsAPl64E y3O0fJcB2t51hSu5/KJNeVRB7lEkDoV2AxlnEioAB4vJDsJ4d60MXfUfvtrsOIubi6tB 0H2WFtDCmj/EQs/tc0f96x0/ZANR04KZEdWJCJdFipN2zFC98IzkhaGHGG02AbZ1Sqbm 72WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6tzBQn21ISHfDplCImGeslYtqyN4YOQPVRToQhASUVY=; b=tos8wZw2+VvmdBCAvRikdl6bHecolUVIdIub4neJLORwH/lVxMyDzZRxplf1vv/UCJ JdWetHzEj+LnX5OXp8EET7MCq2ccgr7hIpc15lk6OwQM1CO39rezSv8xsBM6+ENqPD7q fGzHaUNofPXoxkwidLC/bePGKSPC7hsffumBFJmNBaGz2GE8g2zBxtQ/qFYAIW9nqghX Qko7s4mEKgdbqzWNF7YEXs9ZxWKVjJIkttrDOWlywFP2wJoGPmpOjU+D//1ortOVMHlr ICix8iuhuKfMC5sGg2ObBZtG/gK/Hci6ff3mRk8WZ8RyxGrq9StmfO8x0RNNFvEQEmy8 Hmdw== X-Gm-Message-State: AOAM5304LYofAsvsaGzTVLrjAP3ZhLKWG/ADh44KNcusW4TY9td49RJt In2AdTWIpQ/G5MNdNh2IHhwr5hMTR3iaudVskf4= X-Google-Smtp-Source: ABdhPJxaGRHGr1fnUoBJYB2DuDcGdLzBdN2BoqqbsjtiY+qO7FtCAXUoJSviJ2x8m0W3QCYd0ctKBmkOnhJEbg53W+A= X-Received: by 2002:a17:902:fe0a:b029:11d:81c9:3adf with SMTP id g10-20020a170902fe0ab029011d81c93adfmr11680070plj.0.1625474759804; Mon, 05 Jul 2021 01:45:59 -0700 (PDT) MIME-Version: 1.0 References: <8908f35a741e25a630d521e1012494e67d31ea64.1625466616.git.jie.deng@intel.com> <20210705080245.yabjlrgje5l7vndt@vireshk-i7> In-Reply-To: <20210705080245.yabjlrgje5l7vndt@vireshk-i7> From: Andy Shevchenko Date: Mon, 5 Jul 2021 11:45:23 +0300 Message-ID: Subject: Re: [PATCH v13] i2c: virtio: add a virtio i2c frontend driver To: Viresh Kumar Cc: Jie Deng , linux-i2c , virtualization@lists.linux-foundation.org, Linux Kernel Mailing List , Wolfram Sang , Wolfram Sang , "Michael S. Tsirkin" , Arnd Bergmann , Jason Wang , Andy Shevchenko , yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com, Stefan Hajnoczi , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar wrote: > On 05-07-21, 14:53, Jie Deng wrote: > > +#include > > +#include > > Both of these need to be the uapi headers as Andy said earlier They are already since this header _is_ UAPI, what you are suggesting is gonna not work, although it's correct for in-kernel users of UAPI headers. > and they better > be in alphabetical order. I prefer that as well. > #include > #include -- With Best Regards, Andy Shevchenko