From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
Date: Thu, 25 Jul 2019 21:57:40 +0300 [thread overview]
Message-ID: <CAHp75Vf1pyWjK6hbrNqDjk4v=H0nZLzwKHNK51XteTCo4-QJLA@mail.gmail.com> (raw)
In-Reply-To: <332c666b-1bb3-d4bb-ad1b-98b36992de71@metux.net>
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 25.07.19 19:17, Andy Shevchenko wrote:
> > On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> > <info@metux.net> wrote:
> >>
> >> From: Enrico Weigelt <info@metux.net>
> >>
> >> The keycode KEY_RESTART is more appropriate for the front button,
> >> as most people use it for things like restart or factory reset.
> >>
> >
> > Should it go as Fixes?
>
> I think so. Technically, the feature already worked, but the keycode
> wasn't semantically fine.
Can you provide a Fixes tag?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-07-25 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 11:36 [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button Enrico Weigelt, metux IT consult
2019-07-25 17:17 ` Andy Shevchenko
2019-07-25 18:50 ` Enrico Weigelt, metux IT consult
2019-07-25 18:57 ` Andy Shevchenko [this message]
2019-07-25 19:06 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf1pyWjK6hbrNqDjk4v=H0nZLzwKHNK51XteTCo4-QJLA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).