From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Walle <michael@walle.cc>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 03/15] pinctrl: bcm: add bcm63xx base code
Date: Wed, 10 Mar 2021 16:07:14 +0200 [thread overview]
Message-ID: <CAHp75Vf3ADd+YbnUZni8GL+7_+djUC7bdDK=RuOyGmTYE8LzPQ@mail.gmail.com> (raw)
In-Reply-To: <20210310125504.31886-4-noltari@gmail.com>
On Wed, Mar 10, 2021 at 2:55 PM Álvaro Fernández Rojas
<noltari@gmail.com> wrote:
>
> Add a helper for registering BCM63XX pin controllers.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
(from use of the fwnode API perspective)
I'll think about of_match_node() case and perhaps come up with
corresponding fwnode API solution.
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Co-developed-by: Jonas Gorski <jonas.gorski@gmail.com>
Other way around (Co-DB followed by SoB), but this is minor thingy
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v6: add changes suggested by Andy Shevchenko
> v5: add changes suggested by Andy Shevchenko
> v4: drop IRQ selects from Kconfig and add missing of_node_put()
> v3: add new patch with shared code
>
> drivers/pinctrl/bcm/Kconfig | 7 ++
> drivers/pinctrl/bcm/Makefile | 1 +
> drivers/pinctrl/bcm/pinctrl-bcm63xx.c | 113 ++++++++++++++++++++++++++
> drivers/pinctrl/bcm/pinctrl-bcm63xx.h | 43 ++++++++++
> 4 files changed, 164 insertions(+)
> create mode 100644 drivers/pinctrl/bcm/pinctrl-bcm63xx.c
> create mode 100644 drivers/pinctrl/bcm/pinctrl-bcm63xx.h
>
> diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
> index 0ed14de0134c..882f19bdc243 100644
> --- a/drivers/pinctrl/bcm/Kconfig
> +++ b/drivers/pinctrl/bcm/Kconfig
> @@ -29,6 +29,13 @@ config PINCTRL_BCM2835
> help
> Say Y here to enable the Broadcom BCM2835 GPIO driver.
>
> +config PINCTRL_BCM63XX
> + bool
> + select GENERIC_PINCONF
> + select GPIO_REGMAP
> + select PINCONF
> + select PINMUX
> +
> config PINCTRL_IPROC_GPIO
> bool "Broadcom iProc GPIO (with PINCONF) driver"
> depends on OF_GPIO && (ARCH_BCM_IPROC || COMPILE_TEST)
> diff --git a/drivers/pinctrl/bcm/Makefile b/drivers/pinctrl/bcm/Makefile
> index 79d5e49fdd9a..0e3cf9b15c65 100644
> --- a/drivers/pinctrl/bcm/Makefile
> +++ b/drivers/pinctrl/bcm/Makefile
> @@ -3,6 +3,7 @@
>
> obj-$(CONFIG_PINCTRL_BCM281XX) += pinctrl-bcm281xx.o
> obj-$(CONFIG_PINCTRL_BCM2835) += pinctrl-bcm2835.o
> +obj-$(CONFIG_PINCTRL_BCM63XX) += pinctrl-bcm63xx.o
> obj-$(CONFIG_PINCTRL_IPROC_GPIO) += pinctrl-iproc-gpio.o
> obj-$(CONFIG_PINCTRL_CYGNUS_MUX) += pinctrl-cygnus-mux.o
> obj-$(CONFIG_PINCTRL_NS) += pinctrl-ns.o
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63xx.c b/drivers/pinctrl/bcm/pinctrl-bcm63xx.c
> new file mode 100644
> index 000000000000..2eaac8e6f79f
> --- /dev/null
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm63xx.c
> @@ -0,0 +1,113 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Driver for BCM63xx GPIO unit (pinctrl + GPIO)
> + *
> + * Copyright (C) 2021 Álvaro Fernández Rojas <noltari@gmail.com>
> + * Copyright (C) 2016 Jonas Gorski <jonas.gorski@gmail.com>
> + */
> +
> +#include <linux/gpio/regmap.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +
> +#include "pinctrl-bcm63xx.h"
> +
> +#define BCM63XX_BANK_SIZE 4
> +
> +#define BCM63XX_DIROUT_REG 0x04
> +#define BCM63XX_DATA_REG 0x0c
> +
> +static int bcm63xx_reg_mask_xlate(struct gpio_regmap *gpio,
> + unsigned int base, unsigned int offset,
> + unsigned int *reg, unsigned int *mask)
> +{
> + unsigned int line = offset % BCM63XX_BANK_GPIOS;
> + unsigned int stride = offset / BCM63XX_BANK_GPIOS;
> +
> + *reg = base - stride * BCM63XX_BANK_SIZE;
> + *mask = BIT(line);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id bcm63xx_gpio_of_match[] = {
> + { .compatible = "brcm,bcm6318-gpio", },
> + { .compatible = "brcm,bcm6328-gpio", },
> + { .compatible = "brcm,bcm6358-gpio", },
> + { .compatible = "brcm,bcm6362-gpio", },
> + { .compatible = "brcm,bcm6368-gpio", },
> + { .compatible = "brcm,bcm63268-gpio", },
> + { /* sentinel */ }
> +};
> +
> +static int bcm63xx_gpio_probe(struct device *dev,
> + struct fwnode_handle *node,
> + const struct bcm63xx_pinctrl_soc *soc,
> + struct bcm63xx_pinctrl *pc)
> +{
> + struct gpio_regmap_config grc = {0};
> +
> + grc.parent = dev;
> + grc.fwnode = node;
> + grc.ngpio = soc->ngpios;
> + grc.ngpio_per_reg = BCM63XX_BANK_GPIOS;
> + grc.regmap = pc->regs;
> + grc.reg_mask_xlate = bcm63xx_reg_mask_xlate;
> +
> + if (fwnode_property_read_u32(node, "data", &grc.reg_dat_base))
> + grc.reg_dat_base = BCM63XX_DATA_REG;
> + grc.reg_set_base = grc.reg_dat_base;
> +
> + if (fwnode_property_read_u32(node, "dirout", &grc.reg_dir_out_base))
> + grc.reg_dir_out_base = BCM63XX_DIROUT_REG;
> +
> + return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &grc));
> +}
> +
> +int bcm63xx_pinctrl_probe(struct platform_device *pdev,
> + const struct bcm63xx_pinctrl_soc *soc,
> + void *driver_data)
> +{
> + struct device *dev = &pdev->dev;
> + struct bcm63xx_pinctrl *pc;
> + struct fwnode_handle *node;
> + int err;
> +
> + pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
> + if (!pc)
> + return -ENOMEM;
> +
> + platform_set_drvdata(pdev, pc);
> +
> + pc->dev = dev;
> + pc->driver_data = driver_data;
> +
> + pc->regs = syscon_node_to_regmap(dev->parent->of_node);
> + if (IS_ERR(pc->regs))
> + return PTR_ERR(pc->regs);
> +
> + pc->pctl_desc.name = dev_name(dev);
> + pc->pctl_desc.pins = soc->pins;
> + pc->pctl_desc.npins = soc->npins;
> + pc->pctl_desc.pctlops = soc->pctl_ops;
> + pc->pctl_desc.pmxops = soc->pmx_ops;
> + pc->pctl_desc.owner = THIS_MODULE;
> +
> + pc->pctl_dev = devm_pinctrl_register(dev, &pc->pctl_desc, pc);
> + if (IS_ERR(pc->pctl_dev))
> + return PTR_ERR(pc->pctl_dev);
> +
> + device_for_each_child_node(dev, node) {
> + if (of_match_node(bcm63xx_gpio_of_match, to_of_node(node))) {
> + err = bcm63xx_gpio_probe(dev, node, soc, pc);
> + if (err) {
> + dev_err(dev, "could not add GPIO chip\n");
> + fwnode_handle_put(node);
> + return err;
> + }
> + }
> + }
> +
> + return 0;
> +}
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63xx.h b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
> new file mode 100644
> index 000000000000..3bdb50021f1b
> --- /dev/null
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm63xx.h
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2021 Álvaro Fernández Rojas <noltari@gmail.com>
> + * Copyright (C) 2016 Jonas Gorski <jonas.gorski@gmail.com>
> + */
> +
> +#ifndef __PINCTRL_BCM63XX_H__
> +#define __PINCTRL_BCM63XX_H__
> +
> +#include <linux/pinctrl/pinctrl.h>
> +
> +#define BCM63XX_BANK_GPIOS 32
> +
> +struct bcm63xx_pinctrl_soc {
> + struct pinctrl_ops *pctl_ops;
> + struct pinmux_ops *pmx_ops;
> +
> + const struct pinctrl_pin_desc *pins;
> + unsigned npins;
> +
> + unsigned int ngpios;
> +};
> +
> +struct bcm63xx_pinctrl {
> + struct device *dev;
> + struct regmap *regs;
> +
> + struct pinctrl_desc pctl_desc;
> + struct pinctrl_dev *pctl_dev;
> +
> + void *driver_data;
> +};
> +
> +static inline unsigned int bcm63xx_bank_pin(unsigned int pin)
> +{
> + return pin % BCM63XX_BANK_GPIOS;
> +}
> +
> +int bcm63xx_pinctrl_probe(struct platform_device *pdev,
> + const struct bcm63xx_pinctrl_soc *soc,
> + void *driver_data);
> +
> +#endif /* __PINCTRL_BCM63XX_H__ */
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-10 14:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 12:54 [PATCH v6 00/15] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 02/15] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-10 14:01 ` Andy Shevchenko
2021-03-10 18:27 ` Michael Walle
2021-03-10 19:12 ` Álvaro Fernández Rojas
2021-03-11 1:16 ` Linus Walleij
2021-03-10 12:54 ` [PATCH v6 03/15] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-10 14:07 ` Andy Shevchenko [this message]
2021-03-10 17:50 ` Rob Herring
2021-03-11 1:09 ` Linus Walleij
2021-03-11 14:57 ` Rob Herring
2021-03-11 16:13 ` Linus Walleij
2021-03-11 17:00 ` Álvaro Fernández Rojas
2021-03-11 18:24 ` Rob Herring
2021-03-11 18:32 ` Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 04/15] dt-bindings: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 17:45 ` Rob Herring
2021-03-10 18:03 ` Álvaro Fernández Rojas
2021-03-10 18:45 ` Rob Herring
2021-03-10 19:10 ` Álvaro Fernández Rojas
2021-03-10 20:52 ` Rob Herring
2021-03-11 17:09 ` Álvaro Fernández Rojas
2021-03-11 18:14 ` Rob Herring
2021-03-11 18:34 ` Álvaro Fernández Rojas
2021-03-15 15:57 ` Linus Walleij
2021-03-11 1:22 ` Linus Walleij
2021-03-10 12:54 ` [PATCH v6 05/15] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 06/15] dt-bindings: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 07/15] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 08/15] dt-bindings: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 09/15] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 10/15] dt-bindings: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 12:54 ` [PATCH v6 11/15] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-10 12:55 ` [PATCH v6 12/15] dt-bindings: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 12:55 ` [PATCH v6 13/15] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-10 12:55 ` [PATCH v6 14/15] dt-bindings: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-10 12:55 ` [PATCH v6 15/15] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf3ADd+YbnUZni8GL+7_+djUC7bdDK=RuOyGmTYE8LzPQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fazilyildiran@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=noltari@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).