From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: Eddie James <eajames@linux.ibm.com>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH] spi: Add FSI-attached SPI controller driver
Date: Tue, 4 Feb 2020 13:02:15 +0200 [thread overview]
Message-ID: <CAHp75Vf3NCkbw39E+d_nf+AyViG2o-u5HxrCjXXmbGk4LaFLog@mail.gmail.com> (raw)
In-Reply-To: <29f6cc86-69ca-bc88-b6ae-2b1a24c0dae3@linux.vnet.ibm.com>
On Mon, Feb 3, 2020 at 10:33 PM Eddie James <eajames@linux.vnet.ibm.com> wrote:
> On 1/30/20 10:37 AM, Andy Shevchenko wrote:
> > On Wed, Jan 29, 2020 at 10:09 PM Eddie James <eajames@linux.ibm.com> wrote:
...
> >> + struct device *dev;
> > Isn't fsl->dev the same?
> > Perhaps kernel doc to explain the difference?
>
>
> No, it's not the same, as dev here is the SPI controller. I'll add a
> comment.
Why to have duplication then?
> >> + struct fsi_device *fsi;
...
> >> + for (i = 0; i < num_bytes; ++i)
> >> + rx[i] = (u8)((in >> (8 * ((num_bytes - 1) - i))) & 0xffULL);
> > Redundant & 0xffULL part.
> >
> > Isn't it NIH of get_unalinged_be64 / le64 or something similar?
>
>
> No, these are shift in/out operations. The read register will also have
> previous operations data in them and must be extracted with only the
> correct number of bytes.
Why not to call put_unaligned() how the tail in this case (it's 0 or
can be easily made to be 0) will affect the result?
> >> + return num_bytes;
> >> +}
> >> +static int fsi_spi_data_out(u64 *out, const u8 *tx, int len)
> >> +{
> > Ditto as for above function. (put_unaligned ...)
Ditto.
> >> +}
...
> >> +static int fsi_spi_transfer_data(struct fsi_spi *ctx,
> >> + struct spi_transfer *transfer)
> >> +{
> > Can you refactor to tx and rx parts?
>
>
> Why?
It's way too long function to read. Indentation level also can improve
readability.
That's basically what refactoring is for.
> >> + return 0;
> >> +}
...
> >> + if ((clock_cfg & (SPI_FSI_CLOCK_CFG_MM_ENABLE |
> >> + SPI_FSI_CLOCK_CFG_ECC_DISABLE |
> >> + SPI_FSI_CLOCK_CFG_MODE |
> >> + SPI_FSI_CLOCK_CFG_SCK_RECV_DEL |
> >> + SPI_FSI_CLOCK_CFG_SCK_DIV)) != wanted_clock_cfg)
> >> + rc = fsi_spi_write_reg(ctx, SPI_FSI_CLOCK_CFG,
> >> + wanted_clock_cfg);
> > Missed {} ?
>
>
> No? It's one line under the if.
One statement, but *two* lines.
What does checkpatch.pl tell you about this?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-04 11:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:08 [PATCH] spi: Add FSI-attached SPI controller driver Eddie James
2020-01-30 14:46 ` Mark Brown
2020-01-30 15:32 ` Eddie James
2020-01-30 16:37 ` Andy Shevchenko
2020-02-03 20:33 ` Eddie James
2020-02-04 11:02 ` Andy Shevchenko [this message]
2020-02-04 16:06 ` Eddie James
2020-02-05 15:51 ` Andy Shevchenko
2020-02-07 19:28 ` Eddie James
2020-02-07 19:39 ` Andy Shevchenko
2020-02-07 20:04 ` Eddie James
2020-02-07 20:34 ` Andy Shevchenko
2020-02-07 20:59 ` Eddie James
2020-02-07 22:04 ` Andy Shevchenko
2020-02-10 20:05 ` Eddie James
2020-02-10 20:33 ` Andy Shevchenko
2020-02-10 20:50 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf3NCkbw39E+d_nf+AyViG2o-u5HxrCjXXmbGk4LaFLog@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=eajames@linux.ibm.com \
--cc=eajames@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).