From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dipen Patel <dipenp@nvidia.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kent Gibson <warthog618@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [RFC 00/11] Intro to Hardware timestamping engine
Date: Sun, 27 Jun 2021 16:07:52 +0300 [thread overview]
Message-ID: <CAHp75Vf4TKjtC7cLNape4r+hE-AWnbxtbww2ofCcHQJf9zyh-g@mail.gmail.com> (raw)
In-Reply-To: <20210625235532.19575-1-dipenp@nvidia.com>
On Sat, Jun 26, 2021 at 2:48 AM Dipen Patel <dipenp@nvidia.com> wrote:
>
> This patch series introduces new subsystem called hardware timestamping
> engine (HTE). It offers functionality such as timestamping through hardware
> means in realtime. The HTE subsystem centralizes HTE provider and consumers
> where providers can register themselves with subsystem and the consumers can
> request interested entity which could be lines, GPIO, signals or buses. The
> HTE subsystem provides timestamp in nano seconds, having said that the provider
> need to convert the timestamp if its not in that unit. There was upstream
> discussion about the same at
> https://lore.kernel.org/lkml/4c46726d-fa35-1a95-4295-bca37c8b6fe3@nvidia.com/
>
> To summarize upstream discussion:
> - It was heavily favoured by Linus and Kent to extend GPIOLIB and supporting
> GPIO drivers to add HTE functionality and I agreed to experiment with it.
I guess this series should include more people from different
companies, especially documentation parts. This may be used by
different hardware and quite different vendors. Developing a framework
like this for only one vendor is no go in general.
> This patch series implements and extends GPIOLIB and GPIO tegra driver.
> - Discussed possibility to add HTE provider as irqchip instead which
> was argued against as HTE devices are not necessarily event emitting
> devices.
> - Discussed other possibility if HTE device can be added as posix clock
> type like PTP clocks. That was also argues against since HTE devices
> are not necessarily tightly coupled with hardware clock.
>
> Typical HTE provider does following:
> - Register itself with HTE subsystem
> - Provide *request, *release, *enable, *disable timestamp callbacks and
> optional get_clk_src_info callback to HTE subsystem.
> - Provide optional xlate callback to the subsystem which can translate
> consumer provided logical ids into actual ids of the entity, where entity here
> is the provider dependent and could be GPIO, in chip lines or signals, buses
> etc...This converted id will be used between HTE subsystem and the provider for
> below bullet point.
> - Push timestamps to the subsystem. This happens when HTE provider has
> timestamp data available and willing to push it to HTE subsystem. The HTE
> subsystem stores it into software buffer for the consumers.
> - Unregister itself
>
> Typical HTE consumer does following:
> - Request interested entity it wishes to timestamp in realtime to the
> subsystem. During this call HTE subsystem allocates software buffer to
> store timestamps data.
> - The subsystem does necessary communications with the provider to
> complete the request, which includes translating logical id of the entity to
> provider dependent physical/actual id and enabling hardware timestamping on
> requested id.
> - It can optionally specify callback during registration, this cb will
> be called when provider pushes timestamps. Once notified through cb, the
> consumer can call retrieve API to read the data from the software buffer.
> If cb is not provided, the consumers can elect to call blocking version of
> retrieve API.
> - Manage pre allocated software buffer if needed. It includes changing buffer
> length and watermark/threshold. The subsystem automatically sets watermark or
> threshold at 1, consumers can later change it to any other value it wishes. The
> main purpose for having threshold functionality is to notify consumer either
> through callback if provided or unblock waiting consumer when threshold is
> reached.
> - Retrieve timestamp using various means provided by subsystem.
> - Release entity and its resources.
>
> HTE and GPIOLIB:
> - For the HTE provider which can timestamp GPIO lines.
> - For the GPIO consumers, either in kernel or userspace, The GPIOLIB and its
> CDEV framework are extended as frontend to the HTE by introducing new APIs.
> - Tegra194 AON GPIO controller has HTE support also known as GTE
> (Generic Timestamping Engine). The tegra gpio driver is modified to accommodate
> HTE functionality.
>
> Dipen Patel (11):
> Documentation: Add HTE subsystem guide
> drivers: Add HTE subsystem
> hte: Add tegra194 HTE kernel provider
> dt-bindings: Add HTE bindings
> hte: Add Tegra194 IRQ HTE test driver
> gpiolib: Add HTE support
> gpio: tegra186: Add HTE in gpio-tegra186 driver
> gpiolib: cdev: Add hardware timestamp clock type
> tools: gpio: Add new hardware clock type
> hte: Add tegra GPIO HTE test driver
> MAINTAINERS: Added HTE Subsystem
>
> .../bindings/gpio/nvidia,tegra186-gpio.txt | 7 +
> .../devicetree/bindings/hte/hte-consumer.yaml | 47 +
> .../devicetree/bindings/hte/hte.yaml | 34 +
> .../bindings/hte/nvidia,tegra194-hte.yaml | 83 +
> Documentation/hte/hte.rst | 198 +++
> Documentation/hte/index.rst | 21 +
> Documentation/hte/tegra194-hte.rst | 65 +
> Documentation/index.rst | 1 +
> MAINTAINERS | 8 +
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/gpio/gpio-tegra186.c | 78 +
> drivers/gpio/gpiolib-cdev.c | 65 +-
> drivers/gpio/gpiolib.c | 92 ++
> drivers/gpio/gpiolib.h | 11 +
> drivers/hte/Kconfig | 49 +
> drivers/hte/Makefile | 4 +
> drivers/hte/hte-tegra194-gpio-test.c | 255 +++
> drivers/hte/hte-tegra194-irq-test.c | 400 +++++
> drivers/hte/hte-tegra194.c | 554 +++++++
> drivers/hte/hte.c | 1368 +++++++++++++++++
> include/linux/gpio/consumer.h | 21 +-
> include/linux/gpio/driver.h | 13 +
> include/linux/hte.h | 278 ++++
> include/uapi/linux/gpio.h | 1 +
> tools/gpio/gpio-event-mon.c | 6 +-
> 26 files changed, 3657 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hte/hte-consumer.yaml
> create mode 100644 Documentation/devicetree/bindings/hte/hte.yaml
> create mode 100644 Documentation/devicetree/bindings/hte/nvidia,tegra194-hte.yaml
> create mode 100644 Documentation/hte/hte.rst
> create mode 100644 Documentation/hte/index.rst
> create mode 100644 Documentation/hte/tegra194-hte.rst
> create mode 100644 drivers/hte/Kconfig
> create mode 100644 drivers/hte/Makefile
> create mode 100644 drivers/hte/hte-tegra194-gpio-test.c
> create mode 100644 drivers/hte/hte-tegra194-irq-test.c
> create mode 100644 drivers/hte/hte-tegra194.c
> create mode 100644 drivers/hte/hte.c
> create mode 100644 include/linux/hte.h
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-27 13:08 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:55 [RFC 00/11] Intro to Hardware timestamping engine Dipen Patel
2021-06-25 23:55 ` [RFC 01/11] Documentation: Add HTE subsystem guide Dipen Patel
2021-07-04 18:55 ` Jonathan Cameron
2021-07-27 23:44 ` Dipen Patel
2021-08-01 15:24 ` Jonathan Cameron
2021-06-25 23:55 ` [RFC 02/11] drivers: Add HTE subsystem Dipen Patel
2021-06-27 17:40 ` Randy Dunlap
2021-07-04 20:15 ` Jonathan Cameron
2021-07-04 20:45 ` Jonathan Cameron
2021-07-28 5:12 ` Dipen Patel
2021-08-01 16:48 ` Jonathan Cameron
2021-07-28 4:38 ` Dipen Patel
2021-08-01 16:13 ` Jonathan Cameron
2021-09-14 5:43 ` Dipen Patel
2021-09-26 15:42 ` Jonathan Cameron
2021-07-05 7:30 ` Greg KH
2021-07-28 0:34 ` Dipen Patel
2021-06-25 23:55 ` [RFC 03/11] hte: Add tegra194 HTE kernel provider Dipen Patel
2021-07-01 14:21 ` Kent Gibson
2021-07-28 23:59 ` Dipen Patel
2021-07-30 7:01 ` Dipen Patel
2021-07-31 15:43 ` Kent Gibson
2021-08-03 22:40 ` Dipen Patel
2021-08-03 23:02 ` Kent Gibson
2021-08-07 2:41 ` Dipen Patel
2021-08-07 3:07 ` Kent Gibson
2021-08-07 4:52 ` Dipen Patel
2021-08-07 4:51 ` Kent Gibson
2021-08-07 5:35 ` Dipen Patel
2021-08-07 5:42 ` Kent Gibson
2021-08-07 5:47 ` Dipen Patel
2021-07-04 20:27 ` Jonathan Cameron
2021-07-29 2:42 ` Dipen Patel
2021-07-08 23:33 ` Michał Mirosław
2021-07-29 2:43 ` Dipen Patel
2021-06-25 23:55 ` [RFC 04/11] dt-bindings: Add HTE bindings Dipen Patel
2021-06-27 10:56 ` Linus Walleij
2021-07-30 1:32 ` Dipen Patel
2021-07-01 14:02 ` Rob Herring
2021-07-30 1:56 ` Dipen Patel
2021-07-01 15:54 ` Rob Herring
2021-07-30 1:58 ` Dipen Patel
2021-06-25 23:55 ` [RFC 05/11] hte: Add Tegra194 IRQ HTE test driver Dipen Patel
2021-06-27 17:42 ` Randy Dunlap
2021-06-25 23:55 ` [RFC 06/11] gpiolib: Add HTE support Dipen Patel
2021-06-27 11:41 ` Linus Walleij
2021-07-01 14:24 ` Kent Gibson
2021-07-30 2:25 ` Dipen Patel
2021-07-31 5:13 ` Kent Gibson
2021-06-25 23:55 ` [RFC 07/11] gpio: tegra186: Add HTE in gpio-tegra186 driver Dipen Patel
2021-06-25 23:55 ` [RFC 08/11] gpiolib: cdev: Add hardware timestamp clock type Dipen Patel
2021-06-27 11:38 ` Linus Walleij
2021-06-27 11:49 ` Linus Walleij
2021-07-30 3:16 ` Dipen Patel
2021-07-01 14:24 ` Kent Gibson
2021-07-30 3:07 ` Dipen Patel
2021-07-31 6:05 ` Kent Gibson
2021-08-03 22:41 ` Dipen Patel
2021-08-03 22:38 ` Kent Gibson
2021-07-09 8:30 ` Jon Hunter
2021-07-30 2:33 ` Dipen Patel
2021-08-03 16:42 ` Jon Hunter
2021-08-03 22:51 ` Dipen Patel
2021-08-03 23:09 ` Kent Gibson
2021-06-25 23:55 ` [RFC 09/11] tools: gpio: Add new hardware " Dipen Patel
2021-06-27 11:36 ` Linus Walleij
2021-07-30 3:17 ` Dipen Patel
2021-07-31 6:16 ` Kent Gibson
2021-08-11 9:11 ` Linus Walleij
2021-06-25 23:55 ` [RFC 10/11] hte: Add tegra GPIO HTE test driver Dipen Patel
2021-06-27 17:43 ` Randy Dunlap
2021-06-25 23:55 ` [RFC 11/11] MAINTAINERS: Added HTE Subsystem Dipen Patel
2021-06-27 13:07 ` Andy Shevchenko [this message]
2021-06-27 14:40 ` [RFC 00/11] Intro to Hardware timestamping engine Linus Walleij
2021-06-28 12:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf4TKjtC7cLNape4r+hE-AWnbxtbww2ofCcHQJf9zyh-g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).