From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A63C2D0CD for ; Wed, 18 Dec 2019 10:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B5CE24676 for ; Wed, 18 Dec 2019 10:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="csWjRkJ8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726778AbfLRKRb (ORCPT ); Wed, 18 Dec 2019 05:17:31 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:47052 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbfLRKRb (ORCPT ); Wed, 18 Dec 2019 05:17:31 -0500 Received: by mail-pl1-f196.google.com with SMTP id y8so751734pll.13; Wed, 18 Dec 2019 02:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M9u/AAhgp7vczaWl5nRaS1BNA2aTAiH2Swv5B8ibH/Q=; b=csWjRkJ8ifwjkXfMnaGss5kZ3MngkIY+uU3MmTF0fjYfCz09pVZnvfS0t2+u6fCY5u XiElqaZ2m0CgIWwTkQAsXf8YyGnxyEHVOIJKNokeVb8GZ9kb1AxIeSyqoNU90HU24Mcf T1vZNZ5pKgowYBfyYtzNaWHlW92S1t9iKht+RkFxnw63U005rLNlL0ufy3h1GorbtFzh P/6Hq831StBoti94+hvtB53jy8tsxYzhT3KP4L2mV64tS6G23XyPiPmXUM3qkmZTmyfU 4eb8DUWjzjfxBoU1lzWc/q/5yTIfq0ul4XrtiPe0j+8c+cZXWq/GGZMD4Fn8RTejcuNi tibA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M9u/AAhgp7vczaWl5nRaS1BNA2aTAiH2Swv5B8ibH/Q=; b=jqvoqjVsjIGw41tegF/QbFPAMvr+KBlwmePjTLYpvDliApSLwRK4PjWs24vfTNE+BE cjVes494kNqEbpU8qXqAvvB14E/GfjWldNiOohH+A7I7QBLH/91WmNKfwzOdYlBRNWWm Iy8odnZCsLjR2g45KSMivFWAzpfXzYZv4ZbHRS03gLZlcVH3x+jiPXiz7bICmC3TM3UF 1HQ+TsSvwHkUz3IP9izAwZ+8Jd1b9QrP41RZV3Yp9CPrsFMbzXm0bGtvCodKdQiyN+/P FI7XZKhj6F1hYr0X/+aULsgP/1LTGvHxFJt/q+Pgj1tYEz9PKtYoEuv6rixofsCskEe+ V2Pw== X-Gm-Message-State: APjAAAUy4T8dauCOq8bO372yROQ9Yl5gF9BDhGsrSC2OXvFo2PB73Q9M u9uqYO3aESvBDmhxsJIY/bRjkfkN9uMoH2sYvvY= X-Google-Smtp-Source: APXvYqzkCy2aaHhQ4KsBIIbZJOe/vQs2YULgfDTU+9TvKf8ov3kabEdE3fGrQQXxhlhovh7ZPbPDlSa/0/j4zbEIla8= X-Received: by 2002:a17:902:8d96:: with SMTP id v22mr1849928plo.262.1576664250410; Wed, 18 Dec 2019 02:17:30 -0800 (PST) MIME-Version: 1.0 References: <20191217190604.638467-1-hdegoede@redhat.com> In-Reply-To: <20191217190604.638467-1-hdegoede@redhat.com> From: Andy Shevchenko Date: Wed, 18 Dec 2019 12:17:20 +0200 Message-ID: Subject: Re: [PATCH] platform/x86: hp-wmi: Make buffer for HPWMI_FEATURE2_QUERY 128 bytes To: Hans de Goede Cc: Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List , Stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2019 at 9:06 PM Hans de Goede wrote: > > At least on the HP Envy x360 15-cp0xxx model the WMI interface > for HPWMI_FEATURE2_QUERY requires an outsize of at least 128 bytes, > otherwise it fails with an error code 5 (HPWMI_RET_INVALID_PARAMETERS): > > Dec 06 00:59:38 kernel: hp_wmi: query 0xd returned error 0x5 > > We do not care about the contents of the buffer, we just want to know > if the HPWMI_FEATURE2_QUERY command is supported. > > This commits bumps the buffer size, fixing the error. > Fixes tag? > Cc: stable@vger.kernel.org > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1520703 > Signed-off-by: Hans de Goede > --- > drivers/platform/x86/hp-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index 9579a706fc08..a881b709af25 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -300,7 +300,7 @@ static int __init hp_wmi_bios_2008_later(void) > > static int __init hp_wmi_bios_2009_later(void) > { > - int state = 0; > + u8 state[128]; > int ret = hp_wmi_perform_query(HPWMI_FEATURE2_QUERY, HPWMI_READ, &state, > sizeof(state), sizeof(state)); > if (!ret) > -- > 2.23.0 > -- With Best Regards, Andy Shevchenko