From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Terry Bowman <terry.bowman@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Robert Richter <rrichter@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Mario Limonciello <Mario.Limonciello@amd.com>
Subject: Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function
Date: Wed, 19 Jan 2022 13:40:20 +0200 [thread overview]
Message-ID: <CAHp75VfD2iOF+nkCtOGyAd7sadxJWL2yFKo+zXcrv6E-ADU98g@mail.gmail.com> (raw)
In-Reply-To: <20220118202234.410555-2-terry.bowman@amd.com>
On Tue, Jan 18, 2022 at 10:22 PM Terry Bowman <terry.bowman@amd.com> wrote:
>
> Refactor driver's timer initialization into new function. This is needed
> inorder to support adding new device layouts while using common timer
> initialization.
> Co-developed-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> To: Guenter Roeck <linux@roeck-us.net>
> To: linux-watchdog@vger.kernel.org
> To: Jean Delvare <jdelvare@suse.com>
> To: linux-i2c@vger.kernel.org
> To: Wolfram Sang <wsa@kernel.org>
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Robert Richter <rrichter@amd.com>
> Cc: Thomas Lendacky <thomas.lendacky@amd.com>
Please, do not pollute commit messages with this rather unnecessary
list of recipients. There are (at least?) two possibilities:
- use --cc and --to whe run `git send-email`
- move them under the cutter '--- ' line below
> ---
> + val = readl(SP5100_WDT_CONTROL(tco->tcobase));
> + if (val & SP5100_WDT_DISABLED) {
> + dev_err(dev, "Watchdog hardware is disabled\n");
> + return(-ENODEV);
Missed space, too many parentheses.
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-19 11:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 20:22 [PATCH v3 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O accesses with MMIO accesses Terry Bowman
2022-01-18 20:22 ` [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function Terry Bowman
2022-01-19 11:40 ` Andy Shevchenko [this message]
2022-01-25 13:05 ` Jean Delvare
2022-01-18 20:22 ` [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization Terry Bowman
2022-01-19 11:53 ` Andy Shevchenko
2022-01-19 15:46 ` Guenter Roeck
2022-01-20 11:13 ` Andy Shevchenko
2022-01-19 16:57 ` Terry Bowman
2022-01-19 17:08 ` Guenter Roeck
2022-01-20 11:07 ` Andy Shevchenko
2022-01-25 13:45 ` Jean Delvare
2022-01-25 15:18 ` Terry Bowman
2022-01-25 16:38 ` Jean Delvare
2022-01-25 18:02 ` Terry Bowman
2022-01-25 18:19 ` Jean Delvare
2022-01-18 20:22 ` [PATCH v3 3/4] Watchdog: sp5100_tco: Add initialization using EFCH MMIO Terry Bowman
2022-01-24 17:36 ` Jean Delvare
2022-01-24 19:20 ` Terry Bowman
2022-01-24 22:36 ` Terry Bowman
2022-01-25 12:42 ` Jean Delvare
2022-01-18 20:22 ` [PATCH v3 4/4] Watchdog: sp5100_tco: Enable Family 17h+ CPUs Terry Bowman
2022-01-25 12:43 ` Jean Delvare
2022-01-19 15:30 ` [PATCH v3 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O accesses with MMIO accesses Jean Delvare
2022-01-19 17:33 ` Terry Bowman
2022-01-19 17:47 ` Wolfram Sang
2022-01-19 18:39 ` Guenter Roeck
2022-01-19 18:44 ` Wolfram Sang
2022-01-19 18:45 ` Terry Bowman
2022-01-24 14:42 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfD2iOF+nkCtOGyAd7sadxJWL2yFKo+zXcrv6E-ADU98g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rrichter@amd.com \
--cc=terry.bowman@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=wim@linux-watchdog.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).