From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B71FECAAD5 for ; Mon, 5 Sep 2022 10:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236776AbiIEKzC (ORCPT ); Mon, 5 Sep 2022 06:55:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237965AbiIEKyr (ORCPT ); Mon, 5 Sep 2022 06:54:47 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3139118E1D; Mon, 5 Sep 2022 03:54:38 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id u5so1840287qvv.3; Mon, 05 Sep 2022 03:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=BT3xLpeH3RjbxWQzTHtluGWFLcpz2c3gkUTiSpzfoPpU7gaIO6czvS8W4reMZ4cCO4 3eMf/g+K3UKbJS6Jk0JxrWeNOy6+42NuOyskDMGWojnEiJoNCccaKDrBXpafZBuULjuW dYcA7PiA983MMDKcYZKgKx3pSqByFVARqZpiSeVPU2Zd8gAbIKhjyD904CbNMtAzjOUC uG1HJFkRMuzcZrZpIhoUBQgxwknWCtImNXXD19IvU58Ts2K5UQm4oyao9nlr1q38XCd5 l4cO9hdybc4SBkJmevuxR16Y4XsOdXf+9PHct3p0BX/cs/X4ebLeTYqHTloP7bvoOCLm luuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=kmi0d39df4dc/Shr2iEEyzWx00+hupGAE/iIIwCNnbW+EbPR08zbuQybW+P6It0YIF hyd4UVRGo24295w6EGJtII1ZCpXJ/uOG9xgbqqnJbwHcnAXoFfmjjsvzbczBYTelThob Kl1yCOm0MQ0+i4hGWpy2EChNTaq3+ex0JzRyT3PFVUfRI/C6CvGhbEhclCrgJW15ZcBh o3chJnAHhAvqAnj3sL3C3eMCGQEZikaMHHxguK2AVPUYlip8J6ea+EKbN93JwSF7ruv5 enExdjXvYB03yR9GTiEgYOWeL1Z9EeMF7GdG0baVh/lOO+6Yrf1RzB4ctlGa5GWNc+tb UW/g== X-Gm-Message-State: ACgBeo2lc9Jf9EALtdoDsrTlkjxQCHgwGh47ele3OOUF77s7br9htLVj vY/EmTuOsY5Ub+KiVdC9igP/Tj15ev21tyTY6b4= X-Google-Smtp-Source: AA6agR5qY7QHGswD32uCDWcX3OPsA9Qr7QwZIbiYbOgQNRx+s2EA487X6YBau9sHW1SCIA7Zbx5vkCR0pqATT7Z+4Es= X-Received: by 2002:ad4:5f8f:0:b0:4a9:b75a:e33c with SMTP id jp15-20020ad45f8f000000b004a9b75ae33cmr757802qvb.82.1662375277275; Mon, 05 Sep 2022 03:54:37 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-1-b29adfb27a6c@gmail.com> <20220905071902.fv4uozrsttk3mosu@pali> In-Reply-To: From: Andy Shevchenko Date: Mon, 5 Sep 2022 13:54:00 +0300 Message-ID: Subject: Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Dmitry Torokhov , Thierry Reding , Mark Brown , Matti Vaittinen , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Linus Walleij , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , LINUXWATCHDOG , USB , "open list:GPIO SUBSYSTEM" , linux-pci , linux-tegra , "open list:MEMORY TECHNOLOGY..." , Linux Kernel Mailing List , dri-devel , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 5, 2022 at 1:49 PM Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 10:23 AM Pali Roh=C3=A1r wrote: > > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > ... > > > > - rp->reset_gpio =3D devm_gpiod_get_from_of_node(dev, por= t, > > > - "reset-gpi= os", 0, > > > - GPIOD_OUT_= LOW, > > > - label); > > > + rp->reset_gpio =3D devm_fwnode_gpiod_get(dev, > > > + of_fwnode_handle= (port), > > > + "reset", > > > + GPIOD_OUT_LOW, > > > + label); > > > > Why in pci-aardvark.c for PERST# reset-gpio you have used > > devm_gpiod_get_optional() and here in pci-tegra.c you have used > > devm_fwnode_gpiod_get()? I think that PERST# logic is same in both > > drivers. > > It's not the same dev and its node in this case. There is one reset > for _all_ ports, here is the reset on _per port_ basis. Actually I'm wrong, the aardvark has only one port (?) to serve there. In any case, here dev =3D=3D dev->of_node, here dev !=3D port. --=20 With Best Regards, Andy Shevchenko